Re: CVS commit: pkgsrc/x11/clisp-gtk2

[David Holland <dholland-pkgchanges%netbsd.org@localhost>]

On Thu, Aug 02, 2012 at 01:12:11AM +0400, Aleksej Saushev wrote:
 > > Modified Files:
 > >    pkgsrc/x11/clisp-gtk2: Makefile
 > >
 > > Log Message:
 > > Use ${} instead of $() to appease pkglint.
 > 
 > Please, revert this and all other similar changes.
 > This is useless and stupid. pkglint should be fixed instead.

While I'm inclined to agree, the convention in pkgsrc (and also in
base) has long been to use only ${}, and a lot of people felt strongly
about it.

pkglint also enforces a number of other "purely aesthetic" things that
are enforced for consistency, like the order of declarations. It's not
at all clear that those are markedly different, and fairly clear that
enforcing them has some benefits.

Furthermore, your change to pkglint is incorrect in some fashion, or
maybe just insufficient. With your change, in clisp-gtk2, with ${}, I
get:

ERROR: Makefile: All packages must define their LICENSE.
ERROR: patches/patch-ab:3: Comment expected.
2 errors and 0 warnings found. (Use -e for more details.)

but if I put back the $(), it spews:

ERROR: Makefile: All packages must define their LICENSE.
WARN: Makefile:4: CLISP_MODULE is defined but not used. Spelling mistake?
WARN: Makefile:6: "clisp-$(CLISP_MODULE)-$(CLISP_VERSION)" is not a valid 
package name. A valid package name has the form packagename-version, where 
version consists only of digits, letters and dots.
ERROR: patches/patch-ab:3: Comment expected.
2 errors and 2 warnings found. (Use -e for more details.)

Please fix or revert...

-- 
David A. Holland
dholland%netbsd.org@localhost