Re: CVS commit: pkgsrc/devel/gettext-lib

["OBATA Akio" <obache%netbsd.org@localhost>]

If such packages exist, it means such packages is looking out of
buildlink sandbox.
It should be fixed instead, or other headers and libraries from pkgsrc
also may be used accidentally.

On Wed, 29 Aug 2012 18:01:01 +0900, Steven Drake <sbd%netbsd.org@localhost> 
wrote:

> Module Name:    pkgsrc
> Committed By:   sbd
> Date:           Wed Aug 29 09:01:01 UTC 2012
>
> Modified Files:
>         pkgsrc/devel/gettext-lib: Makefile PLIST buildlink3.mk
>
> Log Message:
> Problem:
>
> 1) The libintl.h from gettext-lib renames the gettext functions so that
>    they are prefixed with 'libintl_' (So that the functions named in
>    libintl don't conflict with any that maybe in libc).
>
> 2) gettext-tools is _always_ built with gettext-lib.
>
> 3) The tools architecture may make gettext-tools a build dependence or
>    someone may choose to install gettext-tools.
>
> 4) The OS has built in gettext.
>
> 5) For some reason ${PREFIX}/include is add to the compiler search path and
>    libintl.h from gettext-lib is found before the system one.
>
> The result is that all the gettext functions are renamed to have the
> 'libintl_' prefix but libintl is not linked with and the following happens:
>
> ${FILENAME}: undefined reference to `libintl_gettext'
> ${FILENAME}: undefined reference to `libintl_textdomain'
> ${FILENAME}: undefined reference to `libintl_bindtextdomain'
> collect2: error: ld returned 1 exit status
>
> Solution:
> Hide libintl.h from gettext-lib in ${PREFIX}/include/gettext then add that
> to the compiler search path when realy needed.
>
> This should permanently fix PR's pkg/24326 pkg/36201 pkg/40153 pkg/43129
> pkg/44009 and pkg/44016.
>
> Bump PKGREVISION.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.52 -r1.53 pkgsrc/devel/gettext-lib/Makefile
> cvs rdiff -u -r1.5 -r1.6 pkgsrc/devel/gettext-lib/PLIST
> cvs rdiff -u -r1.33 -r1.34 pkgsrc/devel/gettext-lib/buildlink3.mk
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.


--
OBATA Akio / obache%NetBSD.org@localhost