Re: CVS commit: pkgsrc/devel/gettext-lib

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

Hi,

From: John Marino <netbsd%marino.st@localhost>, Date: Fri, 31 Aug 2012 19:44:57 
+0200

> On 8/29/2012 11:01, Steven Drake wrote:
>> Module Name: pkgsrc
>> Committed By:        sbd
>> Date:                Wed Aug 29 09:01:01 UTC 2012
>>
>> Modified Files:
>>      pkgsrc/devel/gettext-lib: Makefile PLIST buildlink3.mk
>>
>> Log Message:
>> Problem:
>>
>> 1) The libintl.h from gettext-lib renames the gettext functions so
>> that
>>     they are prefixed with 'libintl_' (So that the functions named in
>>     libintl don't conflict with any that maybe in libc).
>>
>> 2) gettext-tools is _always_ built with gettext-lib.
>>
>> 3) The tools architecture may make gettext-tools a build dependence or
>>     someone may choose to install gettext-tools.
>>
>> 4) The OS has built in gettext.
>>
>> 5) For some reason ${PREFIX}/include is add to the compiler search
>> path and
>>     libintl.h from gettext-lib is found before the system one.
>>
>> The result is that all the gettext functions are renamed to have the
>> 'libintl_' prefix but libintl is not linked with and the following
>> happens:
>>
>> ${FILENAME}: undefined reference to `libintl_gettext'
>> ${FILENAME}: undefined reference to `libintl_textdomain'
>> ${FILENAME}: undefined reference to `libintl_bindtextdomain'
>> collect2: error: ld returned 1 exit status
>>
>> Solution:
>> Hide libintl.h from gettext-lib in ${PREFIX}/include/gettext then add
>> that
>> to the compiler search path when realy needed.
>>
>> This should permanently fix PR's pkg/24326 pkg/36201 pkg/40153
>> pkg/43129
>> pkg/44009 and pkg/44016.
>>
>> Bump PKGREVISION.
>>
> 
> I just started a full bulkbuild that is 1800 packages in and I think I
> already see a regression due to this.
> 
> devel/php-gettext: Configure: error: Cannot locate header file
> libintl.h
> 
> Is there something wrong with php-gettext or this gettext-lib change?

On DragonFly 3.0.1(that uses gettext from pkgsrc, and native gcc 4.4.7),
I have gotten the following errors (cases of normal bmake run
and bmake -d e) on devel/gobject-introspection.

It seems that -I/usr/pkg/include/gettext is not utilized.

=== error message with "bmake build"
  CCLD   gi-dump-types
  CC     glib_print-glib-print.o
  CCLD   glib-print
  GEN    g-ir-scanner
  GEN    g-ir-annotation-tool
  GISCAN GLib-2.0.gir
In file included from <stdin>:36:
/usr/pkg/include/glib/glib-2.0/glib/gi18n.h:25:21: error: libintl.h: No such 
file or directory
Error while processing the source.
gmake[2]: *** [GLib-2.0.gir] Error 1
gmake[2]: Leaving directory 
`/usr/tmp/devel/gobject-introspection/work/gobject-introspection-1.32.1'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory 
`/usr/tmp/devel/gobject-introspection/work/gobject-introspection-1.32.1'
gmake: *** [all] Error 2
*** Error code 2

Stop.
bmake: stopped in /usr/pkgsrc/devel/gobject-introspection
*** Error code 1



== error message with "bmake -d e" (auto-fill-ed with emacs)
*** Failed target:  do-build
*** Failed command: set -e; cd
/usr/tmp/devel/gobject-introspection/work/gobject-introspection-1.32.1
&& cd
/usr/tmp/devel/gobject-introspection/work/gobject-introspection-1.32.1
&& /usr/bin/env USETOOLS=no PTHREAD_CFLAGS=\ -pthread\
PTHREAD_LDFLAGS=\ -pthread PTHREAD_LIBS=-lpthread\ -lrt
PTHREADBASE=/usr DL_CFLAGS= DL_LDFLAGS= DL_LIBS=
PYTHON=/usr/pkg/bin/python2.7 CC=cc CFLAGS=-O2\ -I/usr/pkg/include\
-I/usr/include\ -I/usr/pkg/include/gettext
CPPFLAGS=-I/usr/pkg/include\ -I/usr/include\
-I/usr/pkg/include/gettext CXX=c++ CXXFLAGS=-O2\ -I/usr/pkg/include\
-I/usr/include\ -I/usr/pkg/include/gettext COMPILER_RPATH_FLAG=-Wl,-R
F77=f77 FC=f77 FFLAGS=-O LANG=C LC_COLLATE=C LC_CTYPE=C LC_MESSAGES=C
LC_MONETARY=C LC_NUMERIC=C LC_TIME=C LDFLAGS=-L/usr/pkg/lib\
-Wl,-R/usr/pkg/lib\ -L/usr/lib\ -Wl,-R/usr/lib LINKER_RPATH_FLAG=-R
PATH=/usr/tmp/devel/gobject-introspection/work/.wrapper/bin:/usr/tmp/devel/gobject-introspection/work/.buildlink/bin:/usr/tmp/devel/gobject-introspection/work/.gcc/bin:/usr/tmp/devel/gobject-introspection/work/.tools/bin:/usr/pkg/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/pkg/bin:/usr/pkg/sbin:/usr/games:/usr/local/sbin:/usr/local/bin:/root/bin:/usr/pkg/bin:/usr/pkg/bin
PREFIX=/usr/pkg PKG_SYSCONFDIR=/usr/pkg/etc CXXCPP=cpp
HOME=/usr/tmp/devel/gobject-introspection/work/.home CPP=cpp
LINK_ALL_LIBGCC_HACK= LOCALBASE=/usr/pkg
NO_WHOLE_ARCHIVE_FLAG=-Wl,--no-whole-archive
WHOLE_ARCHIVE_FLAG=-Wl,--whole-archive X11BASE=/usr/pkg
X11PREFIX=/usr/pkg PKGMANDIR=man PKGINFODIR=info MAKECONF=/dev/null
OBJECT_FMT=ELF USETOOLS=no LIBTOOL="libtool "
BSD_INSTALL_PROGRAM=/usr/bin/install\ -c\ -s\ -o\ root\ -g\ wheel\ -m\
755 BSD_INSTALL_SCRIPT=/usr/bin/install\ -c\ -o\ root\ -g\ wheel\ -m\
755 BSD_INSTALL_LIB=/usr/bin/install\ -c\ -o\ root\ -g\ wheel\ -m\ 755
BSD_INSTALL_DATA=/usr/bin/install\ -c\ -o\ root\ -g\ wheel\ -m\ 644
BSD_INSTALL_MAN=/usr/bin/install\ -c\ -o\ root\ -g\ wheel\ -m\ 644
BSD_INSTALL=/usr/bin/install BSD_INSTALL_PROGRAM_DIR=/usr/bin/install\
-d\ -o\ root\ -g\ wheel\ -m\ 755
BSD_INSTALL_SCRIPT_DIR=/usr/bin/install\ -d\ -o\ root\ -g\ wheel\ -m\
755 BSD_INSTALL_LIB_DIR=/usr/bin/install\ -d\ -o\ root\ -g\ wheel\ -m\
755 BSD_INSTALL_DATA_DIR=/usr/bin/install\ -d\ -o\ root\ -g\ wheel\
-m\ 755 BSD_INSTALL_MAN_DIR=/usr/bin/install\ -d\ -o\ root\ -g\ wheel\
-m\ 755 BSD_INSTALL_GAME=/usr/bin/install\ -c\ -s\ -o\ root\ -g\
wheel\ -m\ 2555 BSD_INSTALL_GAME_DATA=/usr/bin/install\ -c\ -o\ root\
-g\ wheel\ -m\ 664 BSD_INSTALL_GAME_DIR=/usr/bin/install\ -d\ -o\
root\ -g\ wheel\ -m\ 775 INSTALL_INFO=
MAKEINFO=/usr/tmp/devel/gobject-introspection/work/.tools/bin/makeinfo
FLEX=/usr/tmp/devel/gobject-introspection/work/.tools/bin/flex
BISON=/usr/tmp/devel/gobject-introspection/work/.tools/bin/bison
PKG_CONFIG=/usr/tmp/devel/gobject-introspection/work/.tools/bin/pkg-config
PKG_CONFIG_LIBDIR=/usr/tmp/devel/gobject-introspection/work/.buildlink/lib/pkgconfig:/usr/tmp/devel/gobject-introspection/work/.buildlink/share/pkgconfig
PKG_CONFIG_LOG=/usr/tmp/devel/gobject-introspection/work/.pkg-config.log
PKG_CONFIG_PATH= WRAPPER_DEBUG=no WRAPPER_UPDATE_CACHE=yes
VIEWBASE=/usr/pkg /usr/pkg/bin/gmake -f Makefile all

--
Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3