Re: CVS commit: pkgsrc/pkgtools/bootstrap-mk-files/files

[Alistair Crooks <agc%pkgsrc.org@localhost>]

On Sat, Feb 23, 2013 at 11:52:33PM +0000, Aleksej Saushev wrote:
> Module Name:  pkgsrc
> Committed By: asau
> Date:         Sat Feb 23 23:52:32 UTC 2013
> 
> Modified Files:
>       pkgsrc/pkgtools/bootstrap-mk-files/files: bootstrap.sh
> 
> Log Message:
> Help people using mk files outside pkgsrc, provide saner default values.

--- pkgsrc/pkgtools/bootstrap-mk-files/files/bootstrap.sh:1.2   Fri Jun 17 
11:00:36 2011
+++ pkgsrc/pkgtools/bootstrap-mk-files/files/bootstrap.sh       Sat Feb 23 
23:52:32 2013
@@ -12,6 +12,14 @@
 # - SYSCONFDIR
 #
 
+: ${CP:=cp}
+: ${SED:=sed}
+: ${OPSYS:=$(uname)}
+: ${ROOT_USER:=$(id -un 0)}
+: ${ROOT_GROUP:=$(id -gn "${ROOT_USER}")}
+: ${MK_DST:=/usr/local/share/mk}
+: ${SYSCONFDIR:=/usr/local/etc}
+
 for file in bsd.README bsd.dep.mk bsd.depall.mk bsd.doc.mk bsd.files.mk \
        bsd.hostprog.mk bsd.inc.mk bsd.info.mk bsd.kernobj.mk bsd.kinc.mk \
        bsd.kmod.mk bsd.lib.mk bsd.links.mk bsd.man.mk bsd.nls.mk \

It's unclear to me why you decided that /usr/local is a "saner" default value
than any other location.

For a start, it's way more likely to collide with other packaging systems
files in that location. It's not "prefix" based, so people have to specify
both MK_DST and SYSCONFDIR when using this by hand.

Yes, these are only default values - but that makes it more important that we
get these correct in the first place.

Regards,
Alistair