CVS commit: pkgsrc/pkgtools/pkglint

["Amitai Schlair" <schmonz%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   schmonz
Date:           Tue Mar 26 15:08:30 UTC 2013

Modified Files:
        pkgsrc/pkgtools/pkglint: Makefile
        pkgsrc/pkgtools/pkglint/files: pkglint.pl
Added Files:
        pkgsrc/pkgtools/pkglint/files: build.pl
        pkgsrc/pkgtools/pkglint/files/PkgLint: CVS_Entry.pm Change.pm
            FileUtil.pm Line.pm Logging.pm SimpleMatch.pm SubstContext.pm
            Type.pm Util.pm VarUseContext.pm

Log Message:
Extract PkgLint::* to files, then inline them.

These bits of non-main functionality are distracting to the casual
reader, and also to your intrepid refactorer. Since we recently
added some characterization tests that run the pkglint executable
against real packages, we can safely extract bits of code to separate
files and prove nothing broke in the move.

Instead of installing the new Perl modules where pkglint can find
them at runtime, I've added a build step to inline them right back
where they used to be (same order and everything). This is a little
annoying, but less annoying than suddenly needing to deal with Perl
runtime paths just for these few tiny modules. Also, loading modules
at runtime would affect pkglint's performance, and I don't yet have
performance tests to prove that this would be fine (or not), so I
can't safely do it.

No functional change intended.


To generate a diff of this commit:
cvs rdiff -u -r1.424 -r1.425 pkgsrc/pkgtools/pkglint/Makefile
cvs rdiff -u -r0 -r1.1 pkgsrc/pkgtools/pkglint/files/build.pl
cvs rdiff -u -r1.850 -r1.851 pkgsrc/pkgtools/pkglint/files/pkglint.pl
cvs rdiff -u -r0 -r1.1 pkgsrc/pkgtools/pkglint/files/PkgLint/CVS_Entry.pm \
    pkgsrc/pkgtools/pkglint/files/PkgLint/Change.pm \
    pkgsrc/pkgtools/pkglint/files/PkgLint/FileUtil.pm \
    pkgsrc/pkgtools/pkglint/files/PkgLint/Line.pm \
    pkgsrc/pkgtools/pkglint/files/PkgLint/Logging.pm \
    pkgsrc/pkgtools/pkglint/files/PkgLint/SimpleMatch.pm \
    pkgsrc/pkgtools/pkglint/files/PkgLint/SubstContext.pm \
    pkgsrc/pkgtools/pkglint/files/PkgLint/Type.pm \
    pkgsrc/pkgtools/pkglint/files/PkgLint/Util.pm \
    pkgsrc/pkgtools/pkglint/files/PkgLint/VarUseContext.pm

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.