Re: CVS commit: pkgsrc/mk/depends

[Jonathan Perkin <jperkin%joyent.com@localhost>]

* On 2014-01-14 at 12:12 GMT, Aleksey Cheusov wrote:

> 
>  >> Module Name:      pkgsrc
>  >> Committed By:     cheusov
>  >> Date:             Tue Jan 14 10:52:12 UTC 2014
>  >> 
>  >> Modified Files:
>  >>   pkgsrc/mk/depends: depends.mk
>  >> 
>  >> Log Message:
>  >> New private target sanity-check-depends for checking DEPENDS,
>  >> BUILD_DEPENDS, TOOL_DEPENDS and CONFLICTS for correctness
>  >> (>x.y.* like patterns). This check is run in the beginning
>  >> of "depend" target.
> 
> > I don't like the expense of this being called by default every single
> > time.
> 
> Runtime for this check is neglible if we compare it with unpacking,
> build and packaging. Packages with broken DEPENDS is more serious
> problem.

You trimmed the part where I said it should go under PKG_DEVELOPER,
which would expose the problem but only when changes are being made to
packages, and to the people who have the ability to fix it.

There is no need to penalise 13,000 package builds for every single
pkgsrc user on earth forever when the occasional packaging error
should be caught before being committed in the first place.

This is the entire reason for PKG_DEVELOPER existing at all.

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com