Re: CVS commit: pkgsrc/graphics/freetype2

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

From: "OBATA Akio" <obata%lins.jp@localhost>, Date: Fri, 14 Mar 2014 23:05:52 
+0900

> On Fri, 14 Mar 2014 22:57:43 +0900, Ryo ONODERA 
> <ryo_on%yk.rim.or.jp@localhost>
> wrote:
> 
>> From: "OBATA Akio" <obata%lins.jp@localhost>, Date: Fri, 14 Mar 2014 22:52:49
>> +0900
>>
>>> On Fri, 14 Mar 2014 22:39:52 +0900, Ryo ONODERA 
>>> <ryo_on%yk.rim.or.jp@localhost>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> From: "OBATA Akio" <obata%lins.jp@localhost>, Date: Fri, 14 Mar 2014 
>>>> 22:16:52
>>>> +0900
>>>>
>>>>> Hi,
>>>>>
>>>>> On Fri, 14 Mar 2014 22:12:34 +0900, Ryo ONODERA 
>>>>> <ryoon%netbsd.org@localhost>
>>>>> wrote:
>>>>>
>>>>>> Module Name:     pkgsrc
>>>>>> Committed By:    ryoon
>>>>>> Date:            Fri Mar 14 13:12:34 UTC 2014
>>>>>>
>>>>>> Modified Files:
>>>>>>  pkgsrc/graphics/freetype2: buildlink3.mk
>>>>>>
>>>>>> Log Message:
>>>>>> graphics/png is also needed now
>>>>>
>>>>> It will break to buildlink for the case using builtin freetype2.
>>>>
>>>> Thank you.
>>>> png should be included only when non-builtin freetype2.
>>>> I have just committed.
>>>
>>> and need to include builtin.mk before using USE_BUILTIN.* (already
>>> fixed).
>>>
>>> Lest parts should be fixed:
>>> * ABI_DEPENDS was bumped to 2.4.12. if it is really required,
>>>   recursive bump is also required.
>>> * this update had been pulled up to pkgsrc-2013Q4 branch, so it
>>>   also should be fixed.
>>
>> Thank you very much.
>> I will do recursive bump.
>>
>> I have no idea about pkgsrc-2013Q4...
> 
> My idea was...
> * No need to bump ABI_DEPENDS.
> * changed png support to be option and disabled by default.
> but more review is required...
> 
> It is the reason why I just noted freetype2-2.5.3 in doc/TODO,
> but not updated...

Looks good to me.

It seems that --with-png=no disables png support.
I will try to make png as option, and reset BUILDLINK_ABI_DEPENDS.

Thank again.

--
Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3