Re: CVS commit: pkgsrc/net/gupnp

[Thomas Klausner <wiz%netbsd.org@localhost>]

On Sun, Jun 22, 2014 at 07:26:46PM +0000, David Holland wrote:
> On Fri, Jun 06, 2014 at 12:33:42PM +0000, Thomas Klausner wrote:
>  > Modified Files:
>  >    pkgsrc/net/gupnp: Makefile PLIST distinfo
>  > 
>  > Log Message:
>  > Update to 0.20.12:
> 
> Does this build for you? I am getting

Yes, it does.
=> Creating binary package /archive/packages/current/All/gupnp-0.20.12.tgz
NetBSD yt.nih.at 6.99.44 NetBSD 6.99.44 (KVOTHE) #54: Fri Jun 20 13:54:36 CEST 
2014  
wiz%yt.nih.at@localhost:/archive/foreign/src/sys/arch/amd64/compile/obj/KVOTHE 
amd64

gcc, modular X.org.

drochner also reported it didn't work for him, but we didn't find out yet why.

> In file included from gupnp.h:27:0,
>                  from gupnp-context-manager.h:28,
>                  from gupnp.h:24,
>                  from gupnp-context-manager.c:46:
> gupnp-device.h:54:29: error: redefinition of typedef 'GUPnPDevice'
> gupnp-acl.h:71:29: note: previous declaration of 'GUPnPDevice' was here
> 
> and looking at the source it seems to be flagrantly wrong.

Please explain what is wrong.

gupnp-device.h has:
typedef struct _GUPnPDevice GUPnPDevice;
...
struct _GUPnPDevice {
        GUPnPDeviceInfo parent;

        GUPnPDevicePrivate *priv;
};

gupnp-acl.h has:
typedef struct _GUPnPDevice GUPnPDevice;

What is the problem?
 Thomas