Re: CVS commit: pkgsrc/mk/pbulk

[Aleksej Saushev <asau%inbox.ru@localhost>]

Jonathan Perkin <jperkin%joyent.com@localhost> writes:

> * On 2014-07-15 at 22:29 BST, Aleksej Saushev wrote:
>
>> Module Name: pkgsrc
>> Committed By:        asau
>> Date:                Tue Jul 15 21:29:39 UTC 2014
>> 
>> Added Files:
>>      pkgsrc/mk/pbulk: pbulk.sh
>> 
>> Log Message:
>> Add helper script for simplified pbulk setup.
>
> Please rename it to pbulk-simple.sh or similar, as I clearly asked for
> in my review.

"I'd like" is not "clearly asked" by any means.

Besides, no rationale was given for this wish, while there's a number of
strong reasons not to call it "simple". In particular, the script is not naive,
it is carefully designed to cover all the most important cases and even more.

> There are a number of different ways to implement pbulk
> helper scripts, and it needs to be clear what each does.

It is not a stupid wrapper to provide access to each and every setting
or to support edge cases like using heterogeneous cluster with some nodes
dedicated to scanning and others to building. There's design decision
behind nearly each second line.

> You should also add your README as a starting point for documenting
> each approach.

It is in the Guide already where it was originally meant to be.


-- 
HE CE3OH...