Re: CVS commit: pkgsrc/mk/platform

[Jonathan Perkin <jperkin%joyent.com@localhost>]

* On 2014-08-28 at 12:36 BST, Richard PALO wrote:

> Le 28/08/14 12:54, Jonathan Perkin a écrit :
> >Module Name: pkgsrc
> >Committed By:        jperkin
> >Date:                Thu Aug 28 10:54:07 UTC 2014
> >
> >Modified Files:
> >     pkgsrc/mk/platform: SunOS.mk
> >
> >Log Message:
> >Remove any -Wl,--* arguments, they are guaranteed to be GNU ld specific
> >and unsupported by the SunOS linker.  Tested to only have positive results
> >in a bulk build.
> >
> >
> >To generate a diff of this commit:
> >cvs rdiff -u -r1.59 -r1.60 pkgsrc/mk/platform/SunOS.mk
> >
> >Please note that diffs are not public domain; they are subject to the
> >copyright notices on the relevant files.
> >
> >
> Hold on there! What about
> -Wl,--strip-all  (well, not that important, given sun strip issues)
> -Wl,--whole-archive
> -Wl,--start-group -Wl,--end-group
> not to mention the supported gnu equivalents for sun ld options?

As I mentioned in the commit message, I ran this through a full bulk
build and there were no regressions.  Packages simply do not use GNU
style arguments when invoking the Sun linker.

This isn't all that surprising, as older versions of Sun ld do not
support any --* style arguments at all, so writing code that way would
only work on very recent versions of SunOS anyway.

If we start to see any packages which do use the long style I'd rather
we fix them (so that they support older releases) rather than having
to keep patching the majority to fix bad --* arguments.

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com