Re: CVS commit: pkgsrc/mk/platform

[Jonathan Perkin <jperkin%joyent.com@localhost>]

* On 2014-08-28 at 16:18 BST, Jonathan Perkin wrote:

> * On 2014-08-28 at 13:07 BST, Richard PALO wrote:
> 
> > Le 28/08/14 13:36, Richard PALO a écrit :
> > >Le 28/08/14 12:54, Jonathan Perkin a écrit :
> > >>Module Name:    pkgsrc
> > >>Committed By:    jperkin
> > >>Date:        Thu Aug 28 10:54:07 UTC 2014
> > >>
> > >>Modified Files:
> > >>    pkgsrc/mk/platform: SunOS.mk
> > >>
> > >>Log Message:
> > >>Remove any -Wl,--* arguments, they are guaranteed to be GNU ld specific
> > >>and unsupported by the SunOS linker.  Tested to only have positive
> > >>results
> > >>in a bulk build.
> > >>
> > >>
> > >>To generate a diff of this commit:
> > >>cvs rdiff -u -r1.59 -r1.60 pkgsrc/mk/platform/SunOS.mk
> > >>
> > >>Please note that diffs are not public domain; they are subject to the
> > >>copyright notices on the relevant files.
> > >>
> > >>
> > >Hold on there! What about
> > >-Wl,--strip-all  (well, not that important, given sun strip issues)
> > >-Wl,--whole-archive
> > >-Wl,--start-group -Wl,--end-group
> > >not to mention the supported gnu equivalents for sun ld options?
> > >
> > BTW, I believe the most common are -Wl,--as-needed & -Wl,--no-as-needed
> > which could be converted to -Wl,-zignore & -Wl,-zrecord on SunOS
> > (and hopefully the remaining border case issues on these in sun ld will be
> > worked out).
> > 
> > Do you have a list of what you encounter?
> 
> In addition to the 11+ packages (some were common infrastructure so
> may be fixing more than 1 package each) I already removed existing
> BUILDLINK_TRANSFORM's for, the current list is:
> 
>   Gauche-0.9.4/build.log:ld: fatal: unrecognized option '--rpath'
>   eggdbus-0.6nb4/build.log:ld: fatal: unrecognized option '--as-needed'
>   fntsample-3.2nb17/build.log:ld: fatal: unrecognized option '--as-needed'
>   grun-0.9.3nb20/build.log:ld: fatal: unrecognized option '--as-needed'
>   gthumb-2.14.4nb13/build.log:ld: fatal: unrecognized option '--as-needed'
>   gthumb-3.0.2nb13/build.log:ld: fatal: unrecognized option '--as-needed'
>   libdevkit-gobject-003nb7/build.log:ld: fatal: unrecognized option 
> '--as-needed'
>   libpinyin-1.0.0/build.log:ld: fatal: unrecognized option 
> '--version-script=./libpinyin.ver'
>   pfe-0.33.71nb7/build.log:ld: fatal: unrecognized option '--warn-common'
>   pinentry-qt-0.8.3nb2/build.log:ld: fatal: unrecognized option '--rpath'
>   scim-python-0.1.13rc1nb22/build.log:ld: fatal: unrecognized option 
> '--version-script=./scim.version-script'
>   scite-3.3.9nb1/build.log:ld: fatal: unrecognized option '--as-needed'
>   scite-3.3.9nb1/build.log:ld: fatal: unrecognized option '--version-script'
>   tuxpaint-0.9.22/build.log:ld: fatal: unrecognized option 
> '--warn-shared-textrel'
> 
> I anticipate the list growing quite a lot once builds are unmasked by
> fixing their broken dependencies.

Ok, for now I've gone with a static list.  I haven't added
transformations for *-as-needed to -z ignore|record as I'd like to see
more testing for those first.

Cheers,

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com