Re: CVS commit: pkgsrc/mk/check

[Jonathan Perkin <jperkin%joyent.com@localhost>]

* On 2014-09-07 at 22:27 BST, Thomas Klausner wrote:

> On Sun, Sep 07, 2014 at 09:48:07AM +0100, Matthias Scheler wrote:
> > On Sat, Sep 06, 2014 at 04:57:51PM +0000, Jonathan Perkin wrote:
> > > Module Name:      pkgsrc
> > > Committed By:     jperkin
> > > Date:             Sat Sep  6 16:57:51 UTC 2014
> > > 
> > > Modified Files:
> > >   pkgsrc/mk/check: check-shlibs-elf.awk
> > > 
> > > Log Message:
> > > Ensure we iterate over the RPATH in search order, rather than relying on
> > > awk array iteration which could result in the wrong library being chosen.
> > > 
> > > Fixes issue seen with GCC 4.9 where the libgcc from the main GCC package
> > > was found first and caused errors, even though the RPATH correctly had
> > > the gcc49-libs version listed first.
> > > 
> > > 
> > > To generate a diff of this commit:
> > > cvs rdiff -u -r1.6 -r1.7 pkgsrc/mk/check/check-shlibs-elf.awk
> > 
> > This causes build failures under NetBSD 7.0_BETA:
> > 
> > => Checking for missing run-time search paths in p5-Params-Validate-1.13
> > ERROR: 
> > lib/perl5/vendor_perl/5.20.0/x86_64-netbsd-thread-multi/auto/Params/Validate/XS/XS.so:
> >  missing library: libc.so.12
> > ERROR: 
> > lib/perl5/vendor_perl/5.20.0/x86_64-netbsd-thread-multi/auto/Params/Validate/XS/XS.so:
> >  missing library: libgcc_s.so.1
> > *** Error code 1
> 
> Also on 7.99.1.

Sorry, I tested this on SunOS and saw no regressions, but NetBSD does
things differently and does not record an RPATH at all for some shared
libraries, and I hadn't accounted for the case where only the system
search paths are used.

Seems to be working fine for me now on 6.1.4.

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com