Re: CVS commit: pkgsrc/x11/gtk3

[Patrick Welche <prlw1%cam.ac.uk@localhost>]

On Sat, Jan 10, 2015 at 12:12:03PM +0900, OBATA Akio wrote:
> On Sat, 10 Jan 2015 07:23:10 +0900, Thomas Klausner <wiz%netbsd.org@localhost> wrote:
> 
> >On Fri, Jan 09, 2015 at 11:29:37AM +0000, OBATA Akio wrote:
> >>Module Name:        pkgsrc
> >>Committed By:       obache
> >>Date:               Fri Jan  9 11:29:37 UTC 2015
> >>
> >>Modified Files:
> >>    pkgsrc/x11/gtk3: Makefile
> >>
> >>Log Message:
> >>Since GTK>=3.14, Adwaita is the default theme, so add dependency on it.
> >>
> >>PR pkg/49494.
> >
> >Well, but adwaita-icon-theme has:
> >
> ># for icontool-render
> >TOOL_DEPENDS+=          gtk3+>=3:../../x11/gtk3
> >
> >So this is not a solution, but introduces a circular dependency.
> 
> The comment is wrong, for "gtk-encode-symbolic-svg".

Correct - I was also trying to use icontool-render to process
distributor-logo.svg at the time, gave up and stuck with rsvg, so
s/icontool-render/gtk-encode-symbolic-svg/

> CONFIGURE_ENV=  ac_cv_path_GTK_ENCODE_SYMBOLIC_SVG="false"
> 
> adwaita-icon-theme is successor of gnome-icon-theme and gnome-icon-theme-symbolic,
> and above trick will drop "gnome-icon-theme-symbolic" part,
> and it is possible provide "adwaita-icon-theme-symbolic" sub package,
> with TOOL_DEPENDS+gtk3+ and BUILD_DIRS= src/symbolic.

I keep changing my mind, and hoped that someone would explain The Right
Way in https://bugzilla.gnome.org/show_bug.cgi?id=741986 but apparently
not.

Say we split out -symbolic, as you suggest, then, as gedit (PR pkg/49494)
uses printer-symbolic, dialog-warning-symbolic, etc., we would end up
needing the dependency on the -symbolic part, so we might as well not
split adwaita, and just add to gedit the dependency on adwaita (as was
done for the PR).

Another way of looking at it is to split the package as you suggest,
and be content with gedit falling back to printer and dialog-warning
when -symbolic isn't found. So gedit would still be usable, but the
package wouldn't be quite right, unless one installed the -symbolic
part, which chances are one would do anyway.

Not much in it to decide...

Cheers,

Patrick