Re: CVS commit: pkgsrc/mk/pkgformat/pkg

["OBATA Akio" <obata%lins.jp@localhost>]

MESSAGE_SRC_DFLT was undocumented, and it was introduction of
 such *_DFLT variables should be gone away
but abandoned.

I have no idea how to determine what kind of commits must be proposed/discussed.
Because I believe that adding "unlink" to tools is very much trivial change than
reverted commits and such changes was just overlooked.
So my only way is "send any proposed changes to pkgsrc-users@ or tech-pkg@ or gnats",
but it is hard for me.
Furthermore it means that anyone approved the change, so no need to commit it to
pkgsrc main tree directly by myself, approved one can do it.  Such workflow
may hard with CVS and GNATS, but it is a issue of this project, and long term unreachable goal,
out of the scope.

I wonder I should change my strategy. from "rely on pkgsrc main tree, and commit my minimal required
infrastructure changes on it" to "fork the whole tree, pull required changes in my tree".
I'm looking for the preferred infrastructure to do such job now.
I'm not using pkgsrc as a business platform, nor bulk build playground with clang, ...
so required packages are not so much.

On Mon, 02 Feb 2015 22:16:42 +0900, Jonathan Perkin <jperkin%joyent.com@localhost> wrote:

> * On 2015-02-02 at 12:32 GMT, OBATA Akio wrote:
>
> > Module Name:    pkgsrc
> > Committed By:   obache
> > Date:           Mon Feb  2 12:32:49 UTC 2015
> >
> > Modified Files:
> >         pkgsrc/mk/pkgformat/pkg: metadata.mk
> >
> > Log Message:
> > Revert
> >  introduce MESSAGE_SRC_DFLT, same as PLIST_SRC_DFLT for PLIST_SRC.
> > proposed/discussed is required for such changes.
>
> Please stop these reverts.  Whilst I understand your frustration with
> regards to the unlink changes, all of these other commits have nothing
> to do with that discussion, and the reverts are potentially harmful.
>
> I haven't seen any objections to the changes you are reverting, and
> even if there were the correct course of action is to discuss them and
> then - and only then - revert if that is the agreed consensus.
>
> Once something has been committed to pkgsrc we are committed to
> supporting it.  By removing these features you are potentially
> breaking users of pkgsrc who have their own local packages, wip, etc.
>
> This is why we work hard to ensure that what does get committed is
> supportable in the long-term, and that once something has been
> committed there must be consensus on its removal, regardless of who
> the original author was.
>
> Please can you therefore:
>
>  - Stop any more reverts.
>
>  - Put back the code that you removed, except for the unlink change.
>
>  - Submit a proposal to tech-pkg@ for the unlink change so that we can
>    discuss it.
>
> Many thanks,


--
???????(^^;
OBATA Akio / obata%lins.jp@localhost
???? ???? ????? ????