CVS commit: pkgsrc/pkgtools/pkglint

["Roland Illig" <rillig%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   rillig
Date:           Wed Mar 11 19:05:58 UTC 2015

Modified Files:
        pkgsrc/pkgtools/pkglint: Makefile
        pkgsrc/pkgtools/pkglint/files: makevars.map pkglint.pl

Log Message:
Fixed a wrong warning for the HOMEPAGE variable

WARN: Makefile:9: Please use ${MASTER_SITE_GITHUB:=glmark2/glmark2}
      instead of "https://github.com/glmark2/glmark2";.

This warning is wrong because HOMEPAGE is neither a plural variable nor
does it contain a "fetch URL".

To fix this, there is a new data type FetchURL, which has one more check
than the existing data type URL, namely the MASTER_SITES abbreviation.
The existing definitions in makevars.map have been updated accordingly
to the appropriate data types.

Note: This patch is not perfect, since ideally only variables of type
"List of FetchURL" should be suggested to be replaced with MASTER_SITES,
but since currently all these variables are actually "List of FetchURL"
and not simply "FetchURL", this should be fine.


To generate a diff of this commit:
cvs rdiff -u -r1.458 -r1.459 pkgsrc/pkgtools/pkglint/Makefile
cvs rdiff -u -r1.261 -r1.262 pkgsrc/pkgtools/pkglint/files/makevars.map
cvs rdiff -u -r1.876 -r1.877 pkgsrc/pkgtools/pkglint/files/pkglint.pl

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.