Re: CVS commit: pkgsrc/lang/gcc49

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

Hi,

From: Jonathan Perkin <jperkin%joyent.com@localhost>, Date: Wed, 10 Jun 2015 21:48:52 +0100

> * On 2015-06-10 at 21:20 BST, Ryo ONODERA wrote:
> 
>> Module Name: pkgsrc
>> Committed By:        ryoon
>> Date:                Wed Jun 10 20:20:42 UTC 2015
>> 
>> Modified Files:
>>      pkgsrc/lang/gcc49: Makefile
>> 
>> Log Message:
>> Fix build under Solaris 10u11.
>> It requires newer binutils and Solaris linker.
>> gfortran part is still broken for me.
> 
> I don't understand this change.  Firstly it will break a lot of
> platforms as your ".else # Solaris 10" actually matches any platform
> which isn't SunOS-5.11+.  Secondly I don't understand why you are
> duplicating a lot of code - the only bit, AIUI, that you need to
> ensure is that Solaris 10 uses GNU as from pkgsrc.

.else is my mistake.
Thanks for your point.
I will fix it.

> What I'd probably do, other than fixing the MACHINE_PLATFORM test, is
> just remove support for /usr/sfw/bin/gas, it's going to be very old on
> Solaris 10 at this point.

I have no idea about /usr/sfw/bin/gas.
And I cannot find why it is used.

So I would not like to change this.

> -- 
> Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com

--
Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3