Re: CVS commit: pkgsrc/pkgtools/bootstrap-mk-files

[Jonathan Perkin <jperkin%joyent.com@localhost>]

* On 2015-07-04 at 13:04 CEST, Ryo ONODERA wrote:

> From: Joerg Sonnenberger <joerg%britannica.bec.de@localhost>, Date: Sat, 4 Jul 2015 12:28:45 +0200
> 
> > On Sat, Jul 04, 2015 at 07:19:08AM +0000, Ryo ONODERA wrote:
> >> Module Name:       pkgsrc
> >> Committed By:      ryoon
> >> Date:              Sat Jul  4 07:19:08 UTC 2015
> >> 
> >> Modified Files:
> >>    pkgsrc/pkgtools/bootstrap-mk-files: Makefile
> >>    pkgsrc/pkgtools/bootstrap-mk-files/files: bsd.lib.mk
> >> Added Files:
> >>    pkgsrc/pkgtools/bootstrap-mk-files/files/mods: QNX.sys.mk
> >> 
> >> Log Message:
> >> Update to 20150704
> >> 
> >> * Improve QNX support.
> >>   From Jan Danielsson.
> > 
> > Please do not change bootstrap stuff without bringing it up tech-pkg@
> > first. While I planned to commit my bsd.lib.mk, it certainly needs
> > *testing* first.
> 
> It works under my QNX 6.5.0 SP1 environemnt.
> 
> I have already reported my test result.
> http://mail-index.netbsd.org/tech-pkg/2015/07/04/msg015145.html
> 
> What is your 'testing'?
> Do you have QNX environment?

You changed the primary bsd.lib.mk, not a QNX 'mods' version, so your
change affects all platforms which do not install their own
modification, which is quite a lot.

Testing requires checking that the change to the primary bsd.lib.mk
does not have adverse effects on those platforms, as your change is
not strictly limited to only QNX.

If you had introduced a new mods/QNX.bsd.lib.mk to cover the lorder
change that would have been a different matter.

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com