Re: CVS commit: pkgsrc/devel/pkg-config

[Richard PALO <richard%netbsd.org@localhost>]

Le 15/10/15 11:47, Thomas Klausner a écrit :
> Module Name:  pkgsrc
> Committed By: wiz
> Date:         Thu Oct 15 09:47:56 UTC 2015
> 
> Modified Files:
>       pkgsrc/devel/pkg-config: Makefile distinfo
>       pkgsrc/devel/pkg-config/patches: patch-configure
>           patch-glib_glib_gtimer.c
> Added Files:
>       pkgsrc/devel/pkg-config/patches: patch-glib_configure
> 
> Log Message:
> Update to 0.29. Regen patches.
> 

This also caused a regression on SunOS...

1st, I needed to enable NLS:
> diff --git a/devel/pkg-config/Makefile b/devel/pkg-config/Makefile
> index 0806073..7718644 100644
> --- a/devel/pkg-config/Makefile
> +++ b/devel/pkg-config/Makefile
> @@ -39,6 +39,7 @@ CONFIGURE_ENV+=               glib_cv_value_AF_INET6=yes
>  
>  .if ${OPSYS} == "SunOS"
>  CONFIGURE_ARGS+=       --disable-dtrace
> +CPPFLAGS+=     -DENABLE_NLS
>  .endif
>  
>  CONFIGURE_ARGS+=       ${CONFIGURE_ARGS.${ICONV_TYPE}-iconv}

from what I understand/understood, this dependency was supposed to go away a few minor releases ago....!

the errors are inappropriate macros defined in glib/glibintl.h causing:
> --- libglib_2_0_la-ggettext.lo ---
> In file included from ggettext.c:30:0:
> /usr/include/libintl.h:67:14: error: expected identifier or '(' before 'const'
>  extern char *dcgettext(const char *, const char *, const int);
>               ^
> /usr/include/libintl.h:68:14: error: expected identifier or '(' before 'const'
>  extern char *dgettext(const char *, const char *);
>               ^
> /usr/include/libintl.h:69:14: error: expected identifier or '(' before 'const'
>  extern char *gettext(const char *);
>               ^
> /usr/include/libintl.h:70:14: error: expected identifier or '(' before 'const'
>  extern char *textdomain(const char *);
>               ^
> glibintl.h:32:38: error: expected ')' before '?' token
>  #define textdomain(String) ((String) ? (String) : "messages")
>                                       ^
> /usr/include/libintl.h:71:14: error: expected identifier or '(' before 'const'
>  extern char *bindtextdomain(const char *, const char *);
>               ^
> /usr/include/libintl.h:79:14: error: expected identifier or '(' before 'unsigned'
>  extern char *dngettext(const char *, const char *,
>               ^
> glibintl.h:36:50: error: expected ')' before '==' token
>  #define dngettext(Domain,String1,String2,N) ((N) == 1 ? (String1) : (String2))
>                                                   ^
> In file included from /usr/include/locale.h:45:0,
>                  from ggettext.c:44:
> /usr/include/libintl.h:82:65: error: expected identifier or '(' before ';' token
>  extern char *bind_textdomain_codeset(const char *, const char *);
>                                                                  ^
> In file included from ggettext.c:30:0:
> ggettext.c: In function 'ensure_gettext_initialized':
> glibintl.h:37:42: warning: statement with no effect [-Wunused-value]
>  #define bindtextdomain(Domain,Directory) (Domain) 
>                                           ^
> ggettext.c:109:7: note: in expansion of macro 'bindtextdomain'
>        bindtextdomain (GETTEXT_PACKAGE, GLIB_LOCALE_DIR);
>        ^
> *** [libglib_2_0_la-ggettext.lo] Error code 1

problem is, if NLS is enabled, then probably gettext-lib should be brought in and... (but that doesn't work...)

Isn't this a probablem as well on NetBSD?
-- 
Richard PALO