Re: CVS commit: pkgsrc/devel/rcs

[Tobias Nygren <tnn%NetBSD.org@localhost>]

On Mon, 2 Nov 2015 12:28:58 +0000
Jonathan Perkin <jperkin%joyent.com@localhost> wrote:

> * On 2015-11-02 at 12:13 GMT, Tobias Nygren wrote:
> 
> > On Mon, 2 Nov 2015 09:49:06 +0000
> > Jonathan Perkin <jperkin%joyent.com@localhost> wrote:
> > 
> > > * On 2015-11-01 at 14:24 GMT, Tobias Nygren wrote:
> > > 
> > > > Modified Files:
> > > >         pkgsrc/devel/rcs: Makefile
> > > > 
> > > > Also LOCALBASE -> PREFIX
> > > 
> > > Why?  LOCALBASE is preferred, and used in all other locations for
> > > tools paths from pkgsrc.
> > 
> > This directly contradicts what "pkglint -e" will tell you if
> > it sees ${LOCALBASE} in the package Makefile.
> 
> Looking at the pkglint explanation, the reasoning (from jlam) is
> mostly obsolete at this point, but also doesn't cover the case of
> referring to tools paths.
> 
> Once I've finished integrating the find-prefix removal I'll update
> pkglint for this.
> 
> For this particular package it doesn't make any difference whether you
> use LOCALBASE or PREFIX, but if this section was copy-pasted into a
> new package which uses INSTALLATION_PREFIX or so it would result in a
> broken tool path, so I think consistent use of LOCALBASE is important.

Then, let's leave it the way it is for now, and do a sweep later after
pkglint is updated to not produce a warning for this.
The claim that LOCALBASE is used in all other locations may be a bit
optimistic. I suspect that at this point in time usage of
${PREFIX}/bin/tool is at least as common as ${LOCALBASE}/bin/tool.

-Tobias