Re: CVS commit: pkgsrc/www/libecap

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Wed, Jun 22, 2016 at 08:15:58PM +0100, Patrick Welche wrote:
> Can of worms: as you can see I can fix squid either with
> 
>    const shared_ptr<libecap::adapter::Service>theService;
> 
> 1) return static_cast<bool>(theService);

This should just be bool(theService).

> 2) return theService != nullptr;

This requires C++11.

> Any style preference between 1) and 2)?

The former is easier.

> But then there is another issue: with your patch, on gcc with no -std
> flag, libecap will contain:
> 
> 000000000000d34a T libecap::RegisterHost(std::tr1::shared_ptr<libecap::host::Host> const&)
> 
> squid3 will then compile with -std=c++11 and look for the function without
> tr1 which doesn't exist in libecap and fail to link.
> 
> We can add -std=c++11 to libecap, which makes your patch even simpler:
> just remove the tr1.
> 
> So what do you suggest?

I don't have an opinion on forcing C++11 mode, I can certainly live with
that.

Joerg