Re: CVS commit: pkgsrc/math/py-Scientific-doc

[Alistair Crooks <agc%pkgsrc.org@localhost>]

On Thursday, July 28, 2016, Joerg Sonnenberger <joerg%bec.de@localhost> wrote:
> On Tue, Jul 26, 2016 at 09:54:45AM -0700, Alistair Crooks wrote:
> > Actually, I disagree - we need to talk about this, as the practice of
> > copying information from the PLIST into the Makefile, having to
> > maintain information in 2 places, and in general muddying the waters
> > between a list of files in the package (the PLIST) and the
> > instructions for building the whole package -- these 2 need to be kept
> > distinct, both logically and physically.
> >
> > If AUTO_MKDIRS isn't working properly, let's fix it, and then make it
> > the default, please
>
> Consider the typical example of
>     ${BSD_INSTALL_PROG} foo ${DESTDIR}${PREFIX}/bin
>
> This will complete successfully, whether bin is a directory or not.
> With AUTO_MKDIRS, removing the PLIST, touching it, running stage-install
> and then print-PLIST > PLIST will have a different result compared to
> just stage-install. As such, I consider the part about creating bin a
> very important and explicit part of the build instructions.
>

 

>
> The PLIST should contain the binary name within the bin dir. Anyone committing a PLIST which includes only the bin name as the last component without checking needs to have a mentor take them aside and clue them in. This is easily checked in pkglint prior to commit. And this part concentrates on the package creator, not the package user; that's one of those optimise for the 1% situations.

We also have the question of why we are duplicating PLIST info unnecessarily in the package Makefile. Ugly, unnecessary and prone to copy and paste errors, to say nothing of maintaining and keeping up to date issues.

>
> Sorry if this formatting comes out wrongly - typed on an iphone