CVS commit: pkgsrc/audio/id3

["Thomas Klausner" <wiz%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   wiz
Date:           Wed Aug 24 09:59:31 UTC 2016

Modified Files:
        pkgsrc/audio/id3: Makefile distinfo
        pkgsrc/audio/id3/patches: patch-aa patch-ab

Log Message:
Updated id3 to 1.0.0.

1.0.0
-----

- Development taken over by Peter Pentchev.
- Import a Debian patch by Stefan Ott <stefan%ott.net@localhost> to
  avoid backquotes in the usage string.
- Import a Debian patch by Stefan Ott <stefan%ott.net@localhost> and
  Peter Pentchev to let the compiler and linker flags be
  overridden.
- Let the install program and the strip flag also be overridden.
- Check some more functions' return values for errors.
- Add some preprocessor and compiler flags to specify certain
  POSIX and C environment standards.
- Reorder the #include statements.
- Also include <strings.h> for strncasecmp().
- Mark the list of genres in genre.h as "const char".
- Add a lot of GCC-specific compiler warning flags.
- Use the err(3) and warn(3) functions, they're portable enough.
- Mark several global variables as static.
- Break the display of the ID3 tags out into a separate function.
- Use "return" from main(), remove unreachable "break" statements.
- Avoid possible out-of-bound copying when storing command-line
  arguments into the new tag structure.
- Expect a C99 compiler and reduce the scope of some variables.
- Use the C99 "bool" type for, well, boolean flags.
- Convert the id3.1 manual page to the mdoc format.
- Fix the fields length in the manual page - only the comment is
  limited to 28 characters, the rest of the text fields are at 30.
- Use the more common "file..." instead of "file1 [file2 [file3...]]"
- Fill in some commonly-used manual page sections.
- Validate number-to-string conversions for the genre and track number.
- Fix a signedness error in the track number display.


To generate a diff of this commit:
cvs rdiff -u -r1.11 -r1.12 pkgsrc/audio/id3/Makefile
cvs rdiff -u -r1.5 -r1.6 pkgsrc/audio/id3/distinfo
cvs rdiff -u -r1.3 -r1.4 pkgsrc/audio/id3/patches/patch-aa
cvs rdiff -u -r1.1 -r1.2 pkgsrc/audio/id3/patches/patch-ab

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/audio/id3/Makefile
diff -u pkgsrc/audio/id3/Makefile:1.11 pkgsrc/audio/id3/Makefile:1.12
--- pkgsrc/audio/id3/Makefile:1.11      Wed Apr 20 12:10:26 2016
+++ pkgsrc/audio/id3/Makefile   Wed Aug 24 09:59:31 2016
@@ -1,15 +1,13 @@
-# $NetBSD: Makefile,v 1.11 2016/04/20 12:10:26 nros Exp $
+# $NetBSD: Makefile,v 1.12 2016/08/24 09:59:31 wiz Exp $
 
-DISTNAME=      id3_0.15.orig
-PKGNAME=       id3-0.15
+DISTNAME=      id3-1.0.0
 CATEGORIES=    audio
-MASTER_SITES=  ${MASTER_SITE_DEBIAN:=pool/main/i/id3/}
+MASTER_SITES=  https://devel.ringlet.net/files/audio/id3/
+EXTRACT_SUFX=  .tar.xz
 
 MAINTAINER=    pkgsrc-users%NetBSD.org@localhost
-#HOMEPAGE=     http://packages.qa.debian.org/i/id3.html
+HOMEPAGE=      https://devel.ringlet.net/audio/id3/
 COMMENT=       ID3 v1.1 tag editor
 LICENSE=       gnu-gpl-v2
 
-WRKSRC=                ${WRKDIR}/${PKGNAME_NOREV}
-
 .include "../../mk/bsd.pkg.mk"

Index: pkgsrc/audio/id3/distinfo
diff -u pkgsrc/audio/id3/distinfo:1.5 pkgsrc/audio/id3/distinfo:1.6
--- pkgsrc/audio/id3/distinfo:1.5       Tue Nov  3 01:12:35 2015
+++ pkgsrc/audio/id3/distinfo   Wed Aug 24 09:59:31 2016
@@ -1,8 +1,8 @@
-$NetBSD: distinfo,v 1.5 2015/11/03 01:12:35 agc Exp $
+$NetBSD: distinfo,v 1.6 2016/08/24 09:59:31 wiz Exp $
 
-SHA1 (id3_0.15.orig.tar.gz) = 5095c2e8963071776adf10df92d94b3fa8934dd8
-RMD160 (id3_0.15.orig.tar.gz) = 85a84f94012971bd79828dee179ffe171fe2eb07
-SHA512 (id3_0.15.orig.tar.gz) = b99f3608fc5494863ddf71b5d15505ea952453777090deb82ea469c1c8ed8cc794907d2fffcd4c5a0aaf6ede260103cd9e720e06244877934b22dfa88e1f2cd0
-Size (id3_0.15.orig.tar.gz) = 12871 bytes
-SHA1 (patch-aa) = 2c3b4f97300489ba7c2ff3d47cbb6654b00abb70
-SHA1 (patch-ab) = e9343a34088e6ca9bbb0315399e9c8e604546c54
+SHA1 (id3-1.0.0.tar.xz) = 26bf0cd599f4754adb453189598df9ce68cce2ec
+RMD160 (id3-1.0.0.tar.xz) = 6616235d06c815357369cd339bb2f50579d9776e
+SHA512 (id3-1.0.0.tar.xz) = 94e88c3a47118bdd2778cc64f5ea009d1a3a872431be945f0dab2f5cbd4b5c82dc61d39049ff1f528ab0f013ccd0e938a856d33d1bda5bc96ecfb9c4284a6e55
+Size (id3-1.0.0.tar.xz) = 13596 bytes
+SHA1 (patch-aa) = 48ded9b7447c8d10f56500ef20a52c5a4a587376
+SHA1 (patch-ab) = bab24712e77be69ca83dc2b22761a361fab30d60

Index: pkgsrc/audio/id3/patches/patch-aa
diff -u pkgsrc/audio/id3/patches/patch-aa:1.3 pkgsrc/audio/id3/patches/patch-aa:1.4
--- pkgsrc/audio/id3/patches/patch-aa:1.3       Mon Nov 24 12:04:15 2008
+++ pkgsrc/audio/id3/patches/patch-aa   Wed Aug 24 09:59:31 2016
@@ -1,20 +1,9 @@
-$NetBSD: patch-aa,v 1.3 2008/11/24 12:04:15 obache Exp $
+$NetBSD: patch-aa,v 1.4 2016/08/24 09:59:31 wiz Exp $
 
---- Makefile.orig      2000-09-23 03:08:39.000000000 +0000
+--- Makefile.orig      2016-08-13 22:39:26.000000000 +0000
 +++ Makefile
-@@ -3,17 +3,17 @@ VERSION = 0.13
- 
- SHELL = /bin/sh
- 
--CC = gcc
--CFLAGS = -g -O2
--LDFLAGS = 
-+#CC = gcc
-+#CFLAGS = -g -O2
-+#LDFLAGS = 
- LIBS = 
- DEFS =  
- INSTALL = /usr/bin/install -c
+@@ -27,9 +27,9 @@ INSTALL ?= /usr/bin/install -c
+ STRIP ?= -s
  
  # Installation directories
 -prefix = ${DESTDIR}/usr
@@ -25,12 +14,12 @@ $NetBSD: patch-aa,v 1.3 2008/11/24 12:04
  bindir = ${exec_prefix}/bin
  
  INCL = 
-@@ -34,7 +34,7 @@ clean:
+@@ -50,7 +50,7 @@ clean:
        rm -f *~ *.o core $(PRODUCT)
  
  install: $(PRODUCT)
 -      $(INSTALL) -d -m 755 $(bindir)
--      $(INSTALL) -s -m 755 -o 0 $(PRODUCT) $(bindir)
+-      $(INSTALL) $(STRIP) -m 755 -o 0 $(PRODUCT) $(bindir)
 -      $(INSTALL) -d -m 755 $(mandir)
 -      $(INSTALL) -m 644 -o 0 $(PRODUCT).1 $(mandir)
 +      $(BSD_INSTALL_PROGRAM_DIR) $(bindir)

Index: pkgsrc/audio/id3/patches/patch-ab
diff -u pkgsrc/audio/id3/patches/patch-ab:1.1 pkgsrc/audio/id3/patches/patch-ab:1.2
--- pkgsrc/audio/id3/patches/patch-ab:1.1       Tue Dec 23 18:11:19 2003
+++ pkgsrc/audio/id3/patches/patch-ab   Wed Aug 24 09:59:31 2016
@@ -1,12 +1,12 @@
-$NetBSD: patch-ab,v 1.1 2003/12/23 18:11:19 sketch Exp $
+$NetBSD: patch-ab,v 1.2 2016/08/24 09:59:31 wiz Exp $
 
---- id3.c.orig 2003-12-23 12:32:28.874414092 +0000
-+++ id3.c      2003-12-23 12:32:49.648359969 +0000
-@@ -34,7 +34,6 @@
- 
- #include <stdio.h>
- #include <stdlib.h>
--#include <getopt.h>
+--- id3.c.orig 2016-08-13 22:39:26.000000000 +0000
++++ id3.c
+@@ -18,7 +18,6 @@
+ #include <ctype.h>
+ #include <err.h>
  #include <errno.h>
- #include <unistd.h>
- #include <string.h>
+-#include <getopt.h>
+ #include <limits.h>
+ #include <stdbool.h>
+ #include <stdio.h>