Re: CVS commit: pkgsrc/www/firefox

[Richard PALO <richard%netbsd.org@localhost>]

Le 08/03/16 22:32, Ryo ONODERA a écrit :
> Module Name:    pkgsrc
> Committed By:   ryoon
> Date:           Tue Mar  8 21:32:52 UTC 2016
>
> Modified Files:
> ...
>             patch-media_libcubeb_src_cubeb__alsa.c

this patch is broke here:

> @@ -531,7 +531,7 @@ $NetBSD: patch-media_libcubeb_src_cubeb_
>       return CUBEB_ERROR_INVALID_FORMAT;
>     }
>
> --  r = snd_pcm_get_params(stm->pcm, &stm->buffer_size, &stm->period_size);
> +-  r = snd_pcm_get_params(stm->pcm, &stm->buffer_size, &period_size);
>  +  r = WRAP(snd_pcm_get_params)(stm->pcm, &stm->buffer_size, &stm->period_size);
>     assert(r == 0);

it should use '&period_size' and not '&stm->period_size'

also, on Ubuntu 16.04 LTS aarch64 the PLIST now needs:

> diff --git a/www/firefox/PLIST b/www/firefox/PLIST
> index 6a8470c..110fe1a 100644
> --- a/www/firefox/PLIST
> +++ b/www/firefox/PLIST
> @@ -3419,6 +3419,7 @@ lib/firefox/components/PackagedAppUtils.js
>  lib/firefox/components/PageThumbsProtocol.js
>  lib/firefox/components/Payment.js
>  lib/firefox/components/PaymentFlowInfo.js
> +lib/firefox/components/PeerConnection.js
>  lib/firefox/components/PermissionSettings.js
>  lib/firefox/components/PhoneNumberService.js
>  lib/firefox/components/PlacesCategoriesStarter.js
> @@ -3546,8 +3547,6 @@ lib/firefox/hyphenation/hyph_sv.dic
>  lib/firefox/hyphenation/hyph_tr.dic
>  lib/firefox/hyphenation/hyph_uk.dic
>  lib/firefox/liblgpllibs.so
> -lib/firefox/libmozavcodec.so
> -lib/firefox/libmozavutil.so
>  lib/firefox/libmozsqlite3.so
>  lib/firefox/libxul.so
>  lib/firefox/modules/AboutReader.jsm


why is it impossible to do a mkpatches/patchdiff/mkpatches -c without
so many false file modifications... and this after 'bmake patch' and 
modify. please make this easier as I have some aarch64 patches I'd like 
to see committed soon if upstream doesn"t.