Re: CVS commit: pkgsrc/net/netatalk3/patches

[coypu%SDF.ORG@localhost]

On Mon, Nov 07, 2016 at 07:37:42AM -0500, Christos Zoulas wrote:
> On Nov 7,  5:47am, coypu%SDF.ORG@localhost (coypu%SDF.ORG@localhost) wrote:
> -- Subject: Re: CVS commit: pkgsrc/net/netatalk3/patches
> 
> | Hi christos!
> | 
> | having patches like patch-etc_afpd_quota.c without a comment in the patch
> | is a little problematic for other people who may interact with the package.
> | 
> | it appears to be changing runtime behaviour to a more correct one.
> | 
> | even if you sent this upstream right away, the next person to update the
> | package will need to remove this patch, which is something requiring
> | confidence that it hasn't broken anything, and from a brief view, it's
> | not clear how to test that the functionality still works.
> | 
> | (although there is some chance it will show as a reversed patch, so
> | easier to understand it just needs to be removed)
> | 
> | could you leave a comment explaining at least what it fixes?
> 
> I will try, but note that most of the patches came from netatalk30...
> So we might have to check who wrote them.
> 
> 
> christos

Oh, then no problem. I thought they are new.