Re: CVS commit: pkgsrc/devel/readline

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Fri, Nov 25, 2016 at 08:56:39AM -0600, John Marino wrote:
> On 11/25/2016 07:19, Joerg Sonnenberger wrote:
> > On Thu, Nov 24, 2016 at 05:54:07PM -0600, John Marino wrote:
> > > On 11/24/2016 17:46, Joerg Sonnenberger wrote:
> > > > On Thu, Nov 24, 2016 at 11:35:19PM +0000, John Marino wrote:
> > > > > There is no termcap library available in any form on DragonFly.
> > > > > Discussed with wiz@.
> > > > 
> > > > But termcap.b3.mk already has fallback logic to curses, so that should
> > > > be used.
> > > > 
> > > 
> > > Please note 2 things:
> > > 1) the other line "CONFIGURE_ARGS+= --with-curses=yes"
> > 
> > That doesn't invalidate anything I said.
> 
> It still requires a conditional statement to handle this configure argument.
> Unless you have OPSYS-specific configure arguments such as
> CONFIGURE_ARGS_DragonFly= --with-curses=yes
> 
> Once the condition is required, then changing the include is in the noise.

Except the hard-coding OS part and that it works against ncurses on many
other systems already. Even then, the correct way if it was really
necessary would be to check the termcap implemenation type and only then
add --with-curses=yes as necessary.

> > > 2) none of the curses / termcap logic works on DragonFly, at all.
> > > 
> > > For many months, curses library is private but the headers were public.
> > > Since pkgsrc doesn't actually test ability to link but only assumes that
> > > header presence == library presence, it's all broken.
> > 
> > Ah, so DragonFly provides a brain dead installation and everything else
> > should cope. I understand.
> 
> wow, do you choose to be this way or can you simply not help it?
> 
> Pkgsrc *claims* to support DragonFly.  This claim is rather dubious because
> it's been broken for well over a year.  You've been party to related PRs and
> didn't lift a finger.

Right, my interest is limited. Given the current situation, I would
prefer to drop any such claims than continue to add more and more hacks.

> If pkgsrc can't utilize readline on a platform, then in effect it doesn't
> support that platform.  The same goes for curses and openssl.

That's bullshit. It works perfectly well on a lot of platforms in
various mixes of installations.

> This wouldn't be necessary if it wasn't for pkgsrc's BRAIN DEAD test
> procedures that fail to test at least for the presence of the library
> yourself.

The same type of checks is present in a lot of packages and likely the
reasons for a lot of the problems you see. There is no sane reason for
providing headers in an accessible place when not providing the
libraries. Zero. It is basically begging for problems.

Joerg