Re: CVS commit: pkgsrc/devel/readline

[David Holland <dholland-pkgchanges%netbsd.org@localhost>]

On Fri, Nov 25, 2016 at 01:02:50PM -0600, John Marino wrote:
 > > > Once the condition is required, then changing the include is in
 > > > the noise.

No, because if you absolutely must must have Dragonfly-specific logic
to avoid use of termcap, the right place for it is in mk/termcap.bl3.mk
so it applies to all termcap users.

However, from what you're describing the thing you want is to put a
PREFER statement in mk/platform/DragonFly.mk to avoid using the
builtin termcap on Dragonfly because it's broken.

Spewing adhoc logic all over everywhere in place of making the proper
changes is destructive in all but the very short term. One of the
reasons you're getting pushback is that you have a history of doing
this and shouting down people who object.

 > A) That implies believing that building it with termcap and falling back to
 > ncurses is more correct than building with ncurses and falling to termcap.

For programs that use the termcap API, of course it is.

 > B) That requires changing several things, all out of scope of this, and
 > requiring having to take point to fix all of them and get approval.

I don't know about where you come from but around here we prefer
fixing things correctly the first time.

 > The status of other platforms is irrelevant.  The fact is that as
 > devel/readline was, it didn't build on DF.

>From what you've described, this really sounds like Dragonfly's bug.

-- 
David A. Holland
dholland%netbsd.org@localhost