Re: CVS commit: pkgsrc/devel

[rodent%NetBSD.org@localhost]

On Mon, Jan 09, 2017 at 11:09:38AM +0900, Takahiro Kambe wrote:
> In message <20170109013015.GB16305%nixsyspaus.org@localhost>
>       on Sun, 8 Jan 2017 20:30:17 -0500,
>       rodent%NetBSD.org@localhost wrote:
> >> 1 out of 1 hunks failed--saving rejects to tilt-1.4.1.gemspec.rej
> > 
> > Not able to reproduce this locally nor on the original test VM.
> Please consider to use lang/ruby/files/update-gemspec.rb modifying
> gemspec files instead of patching them since gemspec file's format
> would be different among ruby's versions.

Yes, I saw that someone had changed the Makefile and removed the patch to use
this framework. However, when testing it, I saw that there was a variable that
wasn't expanding and there was no way it could expand, because gem.mk wasn't
included. From that change, I have no idea how that was able to work at all.
Thus, I removed it and recreated the patch. This package can't include gem.mk,
because of the way its "internal" gems are installed.
 
> And just curious in devel/ruby-redmine/Makefile,
> 
> >> RUBY_VERSIONS_INCOMPATIBLE=        23 # nokogirl version required is broken in 2.3
> 
> How borken it?

What's happening there is when running redmine_fix_gems23.sh upon deployment,
nokogiri ignores all possible ways to make it use system (pkgsrc) libxml and
libxslt. This was fixed in a subsequent version of nokogiri, but the Redmine
package doesn't require this version.