CVS commit: pkgsrc/multimedia/gstreamer1

["Maya Rashish" <maya%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   maya
Date:           Sun Jan 29 23:24:10 UTC 2017

Modified Files:
        pkgsrc/multimedia/gstreamer1: Makefile options.mk

Log Message:
gstreamer1: don't create a setuid binary by default, make an option for it.

gstreamer has gst-ptp-helper - helper for synchronizing time across
the network. I don't believe this option is useful enough to be a default,
but it poses a security risk.

For more information about PTP in Gstreamer, see the following post:
https://coaxion.net/blog/2015/05/ptp-network-clock-support-in-gstreamer/

bump PKGREVISION


To generate a diff of this commit:
cvs rdiff -u -r1.27 -r1.28 pkgsrc/multimedia/gstreamer1/Makefile
cvs rdiff -u -r1.5 -r1.6 pkgsrc/multimedia/gstreamer1/options.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/multimedia/gstreamer1/Makefile
diff -u pkgsrc/multimedia/gstreamer1/Makefile:1.27 pkgsrc/multimedia/gstreamer1/Makefile:1.28
--- pkgsrc/multimedia/gstreamer1/Makefile:1.27  Thu Dec  1 11:08:56 2016
+++ pkgsrc/multimedia/gstreamer1/Makefile       Sun Jan 29 23:24:10 2017
@@ -1,7 +1,8 @@
-# $NetBSD: Makefile,v 1.27 2016/12/01 11:08:56 martin Exp $
+# $NetBSD: Makefile,v 1.28 2017/01/29 23:24:10 maya Exp $
 
 DISTNAME=      gstreamer-1.10.0
 PKGNAME=       ${DISTNAME:S/gstreamer/gstreamer1/}
+PKGREVISION=   1
 CATEGORIES=    multimedia
 MASTER_SITES=  http://gstreamer.freedesktop.org/src/gstreamer/
 EXTRACT_SUFX=  .tar.xz

Index: pkgsrc/multimedia/gstreamer1/options.mk
diff -u pkgsrc/multimedia/gstreamer1/options.mk:1.5 pkgsrc/multimedia/gstreamer1/options.mk:1.6
--- pkgsrc/multimedia/gstreamer1/options.mk:1.5 Thu Dec  1 11:08:56 2016
+++ pkgsrc/multimedia/gstreamer1/options.mk     Sun Jan 29 23:24:10 2017
@@ -1,7 +1,7 @@
-# $NetBSD: options.mk,v 1.5 2016/12/01 11:08:56 martin Exp $
+# $NetBSD: options.mk,v 1.6 2017/01/29 23:24:10 maya Exp $
 
 PKG_OPTIONS_VAR=       PKG_OPTIONS.gstreamer
-PKG_SUPPORTED_OPTIONS= gstreamer-gstcheck introspection
+PKG_SUPPORTED_OPTIONS= gstreamer-gstcheck introspection ptp-suid
 PKG_SUGGESTED_OPTIONS= introspection
 
 .include "../../mk/bsd.options.mk"
@@ -22,3 +22,13 @@ PLIST.introspection=yes
 .else
 CONFIGURE_ARGS+=--disable-introspection
 .endif
+
+# PTP network clock requires setuid root for gst-ptp-helper
+# It's not useful enough to be a default, but left as an option
+# for those interested in it.
+.if !empty(PKG_OPTIONS:Mptp-suid)
+SPECIAL_PERMS+=                libexec/gstreamer-1.0/gst-ptp-helper ${SETUID_ROOT_PERMS}
+CONFIGURE_ARGS+=       --with-ptp-helper-permissions=setuid-root
+.else
+CONFIGURE_ARGS+=       --with-ptp-helper-permissions=none
+.endif