Re: CVS commit: pkgsrc/audio/faac

[Thomas Klausner <wiz%netbsd.org@localhost>]

On Mon, Apr 17, 2017 at 12:04:59PM +0000, maya%netbsd.org@localhost wrote:
> On Mon, Apr 17, 2017 at 08:45:18AM +0000, Thomas Klausner wrote:
> > Module Name:        pkgsrc
> > Committed By:       wiz
> > Date:               Mon Apr 17 08:45:17 UTC 2017
> > 
> > Modified Files:
> >     pkgsrc/audio/faac: options.mk
> > 
> > Log Message:
> > Fix option name, this is libmp4v2, not mpeg4ip.
> > 
> > 
> > To generate a diff of this commit:
> > cvs rdiff -u -r1.4 -r1.5 pkgsrc/audio/faac/options.mk
> > 
> > Please note that diffs are not public domain; they are subject to the
> > copyright notices on the relevant files.
> > 
> 
> > Modified files:
> > 
> > Index: pkgsrc/audio/faac/options.mk
> > diff -u pkgsrc/audio/faac/options.mk:1.4 pkgsrc/audio/faac/options.mk:1.5
> > --- pkgsrc/audio/faac/options.mk:1.4        Fri Feb  9 20:27:16 2007
> > +++ pkgsrc/audio/faac/options.mk    Mon Apr 17 08:45:17 2017
> > @@ -1,13 +1,12 @@
> > -# $NetBSD: options.mk,v 1.4 2007/02/09 20:27:16 drochner Exp $
> > +# $NetBSD: options.mk,v 1.5 2017/04/17 08:45:17 wiz Exp $
> >  
> >  PKG_OPTIONS_VAR=           PKG_OPTIONS.faac
> > -PKG_SUPPORTED_OPTIONS=             mpeg4ip
> > +PKG_SUPPORTED_OPTIONS=             libmp4v2
> >  PKG_SUGGESTED_OPTIONS=
> > -PKG_OPTIONS_LEGACY_OPTS+=  faad:mpeg4ip
> >  
> >  .include "../../mk/bsd.options.mk"
> >  
> > -.if !empty(PKG_OPTIONS:Mmpeg4ip)
> > +.if !empty(PKG_OPTIONS:Mlibmp4v2)
> >  .  include "../../multimedia/libmp4v2/buildlink3.mk"
> >  .else
> >  # ignore bundled mp4v2 lib
> > 
> 
> Why remove PKG_OPTIONS_LEGACY_OPTS?

PKG_OPTIONS_LEGACY_OPTS are only intended to be there for one branch
or two, and that one was definitely older.
 Thomas