Re: CVS commit: pkgsrc/mail

["Johnny C. Lam" <jlam%NetBSD.org@localhost>]

On Mon, Aug 14, 2017 at 04:37:48PM +0100, Jonathan Perkin wrote:
> * On 2017-08-14 at 16:25 BST, Johnny C. Lam wrote:
> 
> > Module Name:        pkgsrc
> > Committed By:       jlam
> > Date:               Mon Aug 14 15:25:36 UTC 2017
> > 
> > Modified Files:
> >     pkgsrc/mail/cyrus-imapd: Makefile
> >     pkgsrc/mail/cyrus-imapd23: Makefile
> > 
> > Log Message:
> > mail/cyrus-imapd{,23}: Remove work directory references in scripts.
> > 
> > The installed cyradm shell script contained the path to the shell
> > in the tools directory instead of the system /bin/sh.  This
> > happened as part of the build process by the Perl MakeMaker system
> > used to build the Cyrus Perl modules.  Make the replacement at
> > post-build time to change it back to /bin/sh.
> 
> Shouldn't this be using ${SHELL}?  Can we guarantee the platform
> /bin/sh is sufficent for this script?

I think ${TOOLS_SH} is likely better, but since I can't test these
changes, I just used the same changes that jnemeth@ made to
cyrus-imapd24.  We can change all three cyrus-imapd* packages at the
same time once we know.  At least the cyrus-imapd24 changes were
already pulled up the previous quarterly release branch, so if this
additional change is made, it should be pulled up as well.

We are fairly lazy about substituting for /bin/sh in installed shell
scripts when we can at least always use ${TOOLS_SH}, which points to
a "good" /bin/sh binary or at least the bootstrapped pdksh binary.
By a loose count, there appear to be 151 packages in pkgsrc that use
REPLACE_SH, but there are probably more than 151 packages that
install shell scripts.

Regards,
-- 
Johnny C. Lam
jlam%NetBSD.org@localhost