Re: CVS commit: pkgsrc/audio/grip

[maya%netbsd.org@localhost]

Hi f2!

thanks for adding the package.

On Fri, Aug 18, 2017 at 12:21:29PM +0000, Fr?d?ric Fauberteau wrote:
> ++#if defined(__NetBSD__)
> ++#include <sys/wait.h>
> ++#endif

I like to check if something is a standard header - in this case
sys/wait.h is a POSIX header.*

(Quick google search will point you at the man page:
http://pubs.opengroup.org/onlinepubs/007904975/basedefs/sys/wait.h.html )

Extra headers, assuming they exist, are often harmless. but it's
possible your reason for needing sys/wait.h may be true for some other
OS, too. so I include them for everyone.

Could you not restrict it to NetBSD?

Thanks!

* I don't think we are trying to support any intentionally-not-POSIX OS,
but upstream may be trying, so something to keep in mind if you are
sending patches upstream