Re: CVS commit: pkgsrc/print/qpdf

[Leonardo Taccari <leot%NetBSD.org@localhost>]

Hello Ryo and all pkgsrc-changes@ readers!

"Ryo ONODERA" writes:
> Module Name:  pkgsrc
> Committed By: ryoon
> Date:         Thu Sep 28 12:50:36 UTC 2017
>
> Modified Files:
>       pkgsrc/print/qpdf: Makefile distinfo
>
> Log Message:
> Update to 7.0.0
> [...]

If I'm not missing something I think that the update to qpdf-7.0.0
introduce a regression in the `.pc' file.
In the `Requires.private:' field now there are:

 Requires.private: zlib, libjpeg

However, at least graphics/jpeg doesn't provide any `.pc' file and all
packages that depends on qpdf and uses the `libqpdf.pc' file provided
fails due non-existent libjpeg (e.g. print/cups-filters).

The attached patch in this email should fix this issue.


OK to commit?
Thank you very much for the attention and thank you Ryo for updating
qpdf!

qpdf: Delete reference to libjpeg in the libqpdf `.pc' file

graphics/jpeg does not provide any `.pc' file this will lead in failures when
invoking pkg-config agaisnt `libqpdf'. Adjust `Requires.private:' in
libqpdf.pc.in to omit libjpeg.

Bump PKGREVISION

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/print/qpdf/Makefile,v
retrieving revision 1.15
diff -u -p -r1.15 Makefile
--- Makefile    29 Sep 2017 21:11:40 -0000      1.15
+++ Makefile    2 Oct 2017 08:51:56 -0000
@@ -1,6 +1,7 @@
 # $NetBSD: Makefile,v 1.15 2017/09/29 21:11:40 wiz Exp $
 
 DISTNAME=      qpdf-7.0.0
+PKGREVISION=   1
 CATEGORIES=    print
 MASTER_SITES=  ${MASTER_SITE_SOURCEFORGE:=qpdf/}
 
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/print/qpdf/distinfo,v
retrieving revision 1.12
diff -u -p -r1.12 distinfo
--- distinfo    28 Sep 2017 12:50:36 -0000      1.12
+++ distinfo    2 Oct 2017 08:51:56 -0000
@@ -4,4 +4,5 @@ SHA1 (qpdf-7.0.0.tar.gz) = 506002271a7e0
 RMD160 (qpdf-7.0.0.tar.gz) = ac3026a820d41dc127823fd3cfe0c1f6af90a4b0
 SHA512 (qpdf-7.0.0.tar.gz) = 7b52d67b4d2c428a7b0c1cd03b03a23f05d38d7e3c81041079a137919019ea5158f12bf95fdcfcff6b43ffdefe93a85127ced2a363a6b4b380cbaa02a3840256
 Size (qpdf-7.0.0.tar.gz) = 7053781 bytes
+SHA1 (patch-libqpdf.pc.in) = f592899487bb958a01931afbe4ddf3c749ea103e
 SHA1 (patch-make_libtool.mk) = 8622d6a446da284269102dde38bf14271363dfdc
Index: patches/patch-libqpdf.pc.in
===================================================================
RCS file: patches/patch-libqpdf.pc.in
diff -N patches/patch-libqpdf.pc.in
--- /dev/null   1 Jan 1970 00:00:00 -0000
+++ patches/patch-libqpdf.pc.in 2 Oct 2017 08:51:56 -0000
@@ -0,0 +1,16 @@
+$NetBSD$
+
+graphics/jpeg does not provide any `.pc' files and adding it to the list of
+`Requires.private:' breaks all packages that need to retrieve pkg-config
+information for libqpdf.
+
+--- libqpdf.pc.in.orig 2017-09-16 17:22:15.000000000 +0000
++++ libqpdf.pc.in
+@@ -6,6 +6,6 @@ includedir=@includedir@
+ Name: libqpdf
+ Description: PDF transformation library
+ Version: @PACKAGE_VERSION@
+-Requires.private: zlib, libjpeg
++Requires.private: zlib
+ Libs: -L${libdir} -lqpdf
+ Cflags: -I${includedir}