CVS commit: pkgsrc/security/netpgpverify/files

["Jonathan Perkin" <jperkin%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   jperkin
Date:           Thu Oct 19 08:23:21 UTC 2017

Modified Files:
        pkgsrc/security/netpgpverify/files: libverify.c verify.h

Log Message:
netpgpverify: Update to 20171019.

Changes since 20170201:

  + Don't overwrite error messages generated by time checks, now the correct
    error is printed instead of the generic "Signature does not match".

  + Remove extraneous newlines from time check errors.

Ok'd agc@


To generate a diff of this commit:
cvs rdiff -u -r1.26 -r1.27 pkgsrc/security/netpgpverify/files/libverify.c
cvs rdiff -u -r1.37 -r1.38 pkgsrc/security/netpgpverify/files/verify.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/security/netpgpverify/files/libverify.c
diff -u pkgsrc/security/netpgpverify/files/libverify.c:1.26 pkgsrc/security/netpgpverify/files/libverify.c:1.27
--- pkgsrc/security/netpgpverify/files/libverify.c:1.26 Wed Feb  1 18:09:26 2017
+++ pkgsrc/security/netpgpverify/files/libverify.c      Thu Oct 19 08:23:21 2017
@@ -2138,18 +2138,18 @@ valid_dates(pgpv_signature_t *signature,
        cc = 0;
        if (signature->birth < pubkey->birth) {
                TIME_SNPRINTF(cc, buf, size, "Signature time (%.24s) was before pubkey creation ", signature->birth);
-               TIME_SNPRINTF(cc, &buf[cc], size - cc, "(%s)\n", pubkey->birth);
+               TIME_SNPRINTF(cc, &buf[cc], size - cc, "(%s)", pubkey->birth);
                return cc;
        }
        now = time(NULL);
        if (signature->expiry != 0) {
                if ((t = signature->birth + signature->expiry) < now) {
-                       TIME_SNPRINTF(cc, buf, size, "Signature expired on %.24s\n", t);
+                       TIME_SNPRINTF(cc, buf, size, "Signature expired on %.24s", t);
                        return cc;
                }
        }
        if (now < signature->birth) {
-               TIME_SNPRINTF(cc, buf, size, "Signature not valid before %.24s\n", signature->birth);
+               TIME_SNPRINTF(cc, buf, size, "Signature not valid before %.24s", signature->birth);
                return cc;
        }
        return 0;
@@ -2167,12 +2167,12 @@ key_expired(pgpv_pubkey_t *pubkey, char 
        cc = 0;
        if (pubkey->expiry != 0) {
                if ((t = pubkey->birth + pubkey->expiry) < now) {
-                       TIME_SNPRINTF(cc, buf, size, "Pubkey expired on %.24s\n", t);
+                       TIME_SNPRINTF(cc, buf, size, "Pubkey expired on %.24s", t);
                        return (int)cc;
                }
        }
        if (now < pubkey->birth) {
-               TIME_SNPRINTF(cc, buf, size, "Pubkey not valid before %.24s\n", pubkey->birth);
+               TIME_SNPRINTF(cc, buf, size, "Pubkey not valid before %.24s", pubkey->birth);
                return (int)cc;
        }
        return 0;
@@ -3222,9 +3222,6 @@ pgpv_verify(pgpv_cursor_t *cursor, pgpv_
                return 0;
        }
        if (!match_sig_id(cursor, pgp, signature, litdata, (unsigned)j, sub)) {
-               snprintf(cursor->why, sizeof(cursor->why),
-                       "Signature does not match %.*s",
-                       (int)obuf.c, (char *)obuf.v);
                return 0;
        }
        ARRAY_APPEND(cursor->datacookies, pkt);

Index: pkgsrc/security/netpgpverify/files/verify.h
diff -u pkgsrc/security/netpgpverify/files/verify.h:1.37 pkgsrc/security/netpgpverify/files/verify.h:1.38
--- pkgsrc/security/netpgpverify/files/verify.h:1.37    Wed Feb  1 18:09:26 2017
+++ pkgsrc/security/netpgpverify/files/verify.h Thu Oct 19 08:23:21 2017
@@ -23,9 +23,9 @@
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 #ifndef NETPGP_VERIFY_H_
-#define NETPGP_VERIFY_H_       20170201
+#define NETPGP_VERIFY_H_       20171019
 
-#define NETPGPVERIFY_VERSION   "netpgpverify portable 20170201"
+#define NETPGPVERIFY_VERSION   "netpgpverify portable 20171019"
 
 #include <sys/types.h>