Re: CVS commit: pkgsrc/math/lp_solve

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Sun, Oct 29, 2017 at 08:45:41PM +0100, Pierre Pronchery wrote:
> On 29/10/2017 19:25, Joerg Sonnenberger wrote:
> > On Sat, Oct 28, 2017 at 11:23:50AM +0000, Pierre Pronchery wrote:
> >> Module Name:       pkgsrc
> >> Committed By:      khorben
> >> Date:              Sat Oct 28 11:23:50 UTC 2017
> >>
> >> Modified Files:
> >>    pkgsrc/math/lp_solve: distinfo
> >>    pkgsrc/math/lp_solve/patches: patch-lp__solve_ccc patch-lpsolve55_ccc
> >>
> >> Log Message:
> >> Fix local privilege escalation when building math/lp_solve
> >>
> >> This still requires $TMPDIR (or /tmp) to be mounted with "exec", but now
> >> respects $TMPDIR.
> > 
> > mktemp -d is not that terribly portable.
> 
> True; I looked for prior art first, and found quite a of few uses,
> including in libarchive, pax, fetch, and pkg_install, or in a number of
> patches from pkgsrc:

Most of those are perfectly optional and have a fallback path.

> Should I revisit this, or is it good enough for now?

Yes. You can just put it into ${WRKDIR}/tmp or so.

Joerg