pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/pkgtools/lintpkgsrc



Hello Jonathan,

Jonathan Perkin writes:
> * On 2017-12-14 at 20:42 GMT, Leonardo Taccari wrote:
> 
> > +SUBST_SED.lp+=     -e s\|@PKG_SYSCONFDIR@\|${PKG_SYSCONFDIR:Q}\|g
> 
> Looks good to me.  Can we just use normal quoting though rather than
> the silly \| stuff (I know you're just copy/pasting from others).
> [...]

Sure, I think all of the SUBST_SED here can be just converted to
SUBST_VARS, and that's even more readable.


Thank you Adam and Jonathan for the quick feedback!



Home | Main Index | Thread Index | Old Index