CVS commit: pkgsrc/devel/gnustep-make

["Greg Troxel" <gdt%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   gdt
Date:           Sun Dec 31 16:39:41 UTC 2017

Modified Files:
        pkgsrc/devel/gnustep-make: gnustep.mk

Log Message:
gnustep-make: Add comments about compiler selection

This package overrides the user-settable variable PKGSRC_COMPILER,
which is irregular.  Add comments/\todos explaining this.

(This is a comment-only change.)


To generate a diff of this commit:
cvs rdiff -u -r1.25 -r1.26 pkgsrc/devel/gnustep-make/gnustep.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/devel/gnustep-make/gnustep.mk
diff -u pkgsrc/devel/gnustep-make/gnustep.mk:1.25 pkgsrc/devel/gnustep-make/gnustep.mk:1.26
--- pkgsrc/devel/gnustep-make/gnustep.mk:1.25   Wed Mar  4 16:51:57 2015
+++ pkgsrc/devel/gnustep-make/gnustep.mk        Sun Dec 31 16:39:41 2017
@@ -1,4 +1,4 @@
-#      $NetBSD: gnustep.mk,v 1.25 2015/03/04 16:51:57 tnn Exp $
+#      $NetBSD: gnustep.mk,v 1.26 2017/12/31 16:39:41 gdt Exp $
 
 .if !defined(GNUSTEP_MK)
 GNUSTEP_MK=            #defined
@@ -9,8 +9,19 @@ PKG_SUPPORTED_OPTIONS+=        fragile
 .include "../../mk/bsd.options.mk"
 
 .if empty(PKG_OPTIONS:Mfragile)
+# It is necessary to use clang to build gnustep packages.
+# PKGSRC_COMPILER is a user-settable variable and may not be set by
+# packages, but there is not a package-settable way to force a
+# different compiler.  For now, abuse it, realizing that this will
+# also drop any ccache or distcc set by the user.
+# \todo Stop abusing PKGSRC_COMPILER.
 PKGSRC_COMPILER=       clang
+
+# \todo Explain.
 ONLY_FOR_COMPILER=     clang
+
+# \todo Explain.  Is this about forcing clang as the compiler, or
+# about using libraries in the clang package, or ?
 BUILDLINK_API_DEPENDS.clang+=   clang>=3.1
 DEPENDS+=              clang-[0-9]*:../../lang/clang
 .endif