CVS commit: pkgsrc/sysutils/py-borgbackup

["Benny Siegert" <bsiegert%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   bsiegert
Date:           Sun Jan  7 14:42:08 UTC 2018

Modified Files:
        pkgsrc/sysutils/py-borgbackup: Makefile distinfo

Log Message:
Update borgbackup to 1.1.4.

Fixes:

- check: data corruption fix: fix for borg check --repair malfunction, #3444.
  See the more detailled notes close to the top of this document.
- delete: also delete security dir when deleting a repo, #3427
- prune: fix building the "borg prune" man page, #3398
- init: use given --storage-quota for local repo, #3470
- init: properly quote repo path in output
- fix startup delay with dns-only own fqdn resolving, #3471

New features:

- added zstd compression. try it!
- added placeholder {reverse-fqdn} for fqdn in reverse notation
- added BORG_BASE_DIR environment variable, #3338

Other changes:

- list help topics when invalid topic is requested
- fix lz4 deprecation warning, requires lz4 >= 1.7.0 (r129)
- add parens for C preprocessor macro argument usages (did not cause malfunction)
- exclude broken pytest 3.3.0 release
- updated fish/bash completions
- init: more clear exception messages for borg create, #3465
- docs:

  - add auto-generated docs for borg config
  - don't generate HTML docs page for borgfs, #3404
  - docs update for lz4 b2 zstd changes
  - add zstd to compression help, readme, docs
  - update requirements and install docs about bundled lz4 and zstd
- refactored build of the compress and crypto.low_level extensions, #3415:

  - move some lib/build related code to setup_{zstd,lz4,b2}.py
  - bundle lz4 1.8.0 (requirement: >= 1.7.0 / r129)
  - bundle zstd 1.3.2 (requirement: >= 1.3.0)
  - blake2 was already bundled
  - rename BORG_LZ4_PREFIX env var to BORG_LIBLZ4_PREFIX for better consistency:
    we also have BORG_LIBB2_PREFIX and BORG_LIBZSTD_PREFIX now.
  - add prefer_system_lib* = True settings to setup.py - by default the build
    will prefer a shared library over the bundled code, if library and headers
    can be found and meet the minimum requirements.

Pre-1.1.4 potential data corruption issue
-----------------------------------------

A data corruption bug was discovered in borg check --repair, see issue #3444.

This is a 1.1.x regression, releases < 1.1 (e.g. 1.0.x) are not affected.

To avoid data loss, you must not run borg check --repair using an unfixed version
of borg 1.1.x. The first official release that has the fix is 1.1.4.

Package maintainers may have applied the fix to updated packages of 1.1.x (x<4)
though, see the package maintainer's package changelog to make sure.

If you never had missing item metadata chunks, the bug has not affected you
even if you did run borg check --repair with an unfixed version.

When borg check --repair tried to repair corrupt archives that miss item metadata
chunks, the resync to valid metadata in still present item metadata chunks
malfunctioned. This was due to a broken validator that considered all (even valid)
item metadata as invalid. As they were considered invalid, borg discarded them.
Practically, that means the affected files, directories or other fs objects were
discarded from the archive.

Due to the malfunction, the process was extremely slow, but if you let it
complete, borg would have created a "repaired" archive that has lost a lot of items.
If you interrupted borg check --repair because it was so strangely slow (killing
borg somehow, e.g. Ctrl-C) the transaction was rolled back and no corruption occurred.

The log message indicating the precondition for the bug triggering looks like:

    item metadata chunk missing [chunk: 001056_bdee87d...a3e50d]

If you never had that in your borg check --repair runs, you're not affected.

But if you're unsure or you actually have seen that, better check your archives.
By just using "borg list repo::archive" you can see if all expected filesystem
items are listed.


To generate a diff of this commit:
cvs rdiff -u -r1.15 -r1.16 pkgsrc/sysutils/py-borgbackup/Makefile
cvs rdiff -u -r1.9 -r1.10 pkgsrc/sysutils/py-borgbackup/distinfo

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/sysutils/py-borgbackup/Makefile
diff -u pkgsrc/sysutils/py-borgbackup/Makefile:1.15 pkgsrc/sysutils/py-borgbackup/Makefile:1.16
--- pkgsrc/sysutils/py-borgbackup/Makefile:1.15 Sun Dec 10 08:30:01 2017
+++ pkgsrc/sysutils/py-borgbackup/Makefile      Sun Jan  7 14:42:08 2018
@@ -1,6 +1,6 @@
-# $NetBSD: Makefile,v 1.15 2017/12/10 08:30:01 adam Exp $
+# $NetBSD: Makefile,v 1.16 2018/01/07 14:42:08 bsiegert Exp $
 
-DISTNAME=      borgbackup-1.1.3
+DISTNAME=      borgbackup-1.1.4
 PKGNAME=       ${PYPKGPREFIX}-${DISTNAME}
 CATEGORIES=    sysutils python
 MASTER_SITES=  ${MASTER_SITE_PYPI:=b/borgbackup/}

Index: pkgsrc/sysutils/py-borgbackup/distinfo
diff -u pkgsrc/sysutils/py-borgbackup/distinfo:1.9 pkgsrc/sysutils/py-borgbackup/distinfo:1.10
--- pkgsrc/sysutils/py-borgbackup/distinfo:1.9  Sat Dec  2 08:53:10 2017
+++ pkgsrc/sysutils/py-borgbackup/distinfo      Sun Jan  7 14:42:08 2018
@@ -1,6 +1,6 @@
-$NetBSD: distinfo,v 1.9 2017/12/02 08:53:10 bsiegert Exp $
+$NetBSD: distinfo,v 1.10 2018/01/07 14:42:08 bsiegert Exp $
 
-SHA1 (borgbackup-1.1.3.tar.gz) = 4c1451467d49319fbc827a0d42665a8a9e9a985f
-RMD160 (borgbackup-1.1.3.tar.gz) = 33125a91cf45eebffad85513b32d4dc6417de295
-SHA512 (borgbackup-1.1.3.tar.gz) = 8378e4f805bfb3e9a4e454f5ccfa58eef0517f13a2e8a2c3c6cbdb0304b763fa67152963b17d677daff09590eb777f12fbe1f3f69c3459bcc68781e5a747cb49
-Size (borgbackup-1.1.3.tar.gz) = 2942183 bytes
+SHA1 (borgbackup-1.1.4.tar.gz) = e3c26df1dc7f18a1798b1286a17c637bba6b9d9a
+RMD160 (borgbackup-1.1.4.tar.gz) = b8375cd66fb3f6567bb9c68721c75eb3093cbaa0
+SHA512 (borgbackup-1.1.4.tar.gz) = 0853033f72406a2913dd74c6ebb8b33a318179843255c92481f5e4fdd0f436de6e4c77eed259a422e00bfadcf260facdfd00c813bb0628b82b8ff63a87e1bcfb
+Size (borgbackup-1.1.4.tar.gz) = 3390046 bytes