pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/games



Am 14/01/2018 um 07:45 schrieb Jonathan Perkin:
* On 2018-01-14 at 17:34 GMT, Roland Illig wrote:

-PYCOMPILEALL=  ${BUILDLINK_PREFIX.${PYPACKAGE}}/${PYLIB}/compileall.py
+PYCOMPILEALL=                  ${BUILDLINK_PREFIX.${PYPACKAGE}}/${PYLIB}/compileall.py
  PYTHON_VERSIONS_INCOMPATIBLE= 34 35 36 # not yet ported as of 0.3

I don't like this transformation if it's going to make lines >80
characters, just move PYTHON_VERSIONS_INCOMPATIBLE to its own
paragraph and leave PYCOMPILEALL with a sensible indent.

This makes sense to me. The established pkgsrc practice is that a single "outlier" line is allowed to stick out from the rest, and I'm currently implementing this. It's a little trickier than I thought, and until I have sorted out the remaining corner cases, I won't do such commits again. I plan to finish this in the next two or three weeks.

If you are interested in the ongoing process, it's here:
https://github.com/rillig/pkglint/blob/master/mklines_test.go
The interesting tests have "align" in their names.

Roland



Home | Main Index | Thread Index | Old Index