Re: CVS commit: pkgsrc/devel/py-flake8

[Adam <adam%netbsd.org@localhost>]

I am still having issues with TEST_DEPENDS: it seems like ${WRKDIR}/.error is not created for TEST_DEPEND'end packages, and testing fails. For example, while testing py-flake, and not having 
py-test-runner installed, my build ends with:

=> Checking file-check results for py36-test-runner-4.2
/dist/pkg/bin/pdksh: cannot create /tmp/pkgsrc/devel/py-test-runner/work/.error/check-files-prefix: No such file or directory
*** Error code 1

What's missing?

Kind regards,
Adam


> Module Name:  pkgsrc
> Committed By: joerg
> Date:         Wed Mar 21 12:05:28 UTC 2018
> 
> Modified Files:
>       pkgsrc/devel/py-flake8: Makefile
> 
> Log Message:
> Switch to TEST_DEPENDS to unbreak dependency loop.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.11 -r1.12 pkgsrc/devel/py-flake8/Makefile
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
> 
> Modified files:
> 
> Index: pkgsrc/devel/py-flake8/Makefile
> diff -u pkgsrc/devel/py-flake8/Makefile:1.11 pkgsrc/devel/py-flake8/Makefile:1.12
> --- pkgsrc/devel/py-flake8/Makefile:1.11      Mon Oct 23 20:44:27 2017
> +++ pkgsrc/devel/py-flake8/Makefile   Wed Mar 21 12:05:28 2018
> @@ -1,4 +1,4 @@
> -# $NetBSD: Makefile,v 1.11 2017/10/23 20:44:27 adam Exp $
> +# $NetBSD: Makefile,v 1.12 2018/03/21 12:05:28 joerg Exp $
> 
> DISTNAME=     flake8-3.5.0
> PKGNAME=      ${PYPKGPREFIX}-${DISTNAME}
> @@ -22,9 +22,9 @@ DEPENDS+=   ${PYPKGPREFIX}-enum34-[0-9]*:.
> # TEST_DEPENDS
> # 8 test failures as of 3.0.4, see
> # https://gitlab.com/pycqa/flake8/issues/232
> -BUILD_DEPENDS+=      ${PYPKGPREFIX}-mock-[0-9]*:../../devel/py-mock
> -BUILD_DEPENDS+=      ${PYPKGPREFIX}-test-[0-9]*:../../devel/py-test
> -BUILD_DEPENDS+=      ${PYPKGPREFIX}-test-runner-[0-9]*:../../devel/py-test-runner
> +TEST_DEPENDS+=       ${PYPKGPREFIX}-mock-[0-9]*:../../devel/py-mock
> +TEST_DEPENDS+=       ${PYPKGPREFIX}-test-[0-9]*:../../devel/py-test
> +TEST_DEPENDS+=       ${PYPKGPREFIX}-test-runner-[0-9]*:../../devel/py-test-runner
> 
> post-install:
>       cd ${DESTDIR}${PREFIX}/bin && ${MV} flake8 flake8-${PYVERSSUFFIX} || ${TRUE}
>