Re: CVS commit: pkgsrc/fonts/fontconfig

["Amitai Schleier" <schmonz%schmonz.com@localhost>]

On 24 Mar 2018, at 9:44, Filip Hajny wrote:

> Module Name:    pkgsrc
> Committed By:   fhajny
> Date:           Sat Mar 24 15:44:54 UTC 2018
>
> Modified Files:
>         pkgsrc/fonts/fontconfig: Makefile PLIST
>
> Log Message:
> fonts/fontconfig: Requires devel/gettext-lib. Bump PKGREVISION, may 
> result in a PLIST change.

At least on Darwin 17.4.0, multimedia/libbluray fails to link for lack 
of -lintl.

libbluray doesn't use gettext directly, so it must be the case that one 
of its dependencies does, and that dependency's buildlink3.mk must be 
failing to include gettext-lib.

libbluray buildlinks with fontconfig, freetype2, and libxml2. "otool -L" 
on freetype2 and libxml2 shows no runtime linkage with libintl; 
fontconfig, as of this change, does have one.

The following one-liner seems consistent with this Makefile change, and 
fixes libbluray for me. OK to commit?

Index: buildlink3.mk
===================================================================
RCS file: /cvsroot/pkgsrc/fonts/fontconfig/buildlink3.mk,v
retrieving revision 1.34
diff -u -r1.34 buildlink3.mk
--- buildlink3.mk       12 Mar 2018 11:15:32 -0000      1.34
+++ buildlink3.mk       25 Mar 2018 17:32:22 -0000
@@ -9,6 +9,7 @@
 BUILDLINK_ABI_DEPENDS.fontconfig+=     fontconfig>=2.13.0
 BUILDLINK_PKGSRCDIR.fontconfig?=       ../../fonts/fontconfig

+.include "../../devel/gettext-lib/buildlink3.mk"
 .include "../../devel/zlib/buildlink3.mk"
 .include "../../devel/libuuid/buildlink3.mk"
 .include "../../graphics/freetype2/buildlink3.mk"