Re: CVS commit: pkgsrc/security/gnupg2

[Thomas Merkel <tm%netbsd.org@localhost>]

Hello,

* Leonardo Taccari <leot%NetBSD.org@localhost> [2018-05-08 15:52]:
> Hello Adam and Thomas,
> 
> Adam writes:
> > Please, don't bump revisions for changes that do not make any difference to the default behaviour. In this case, you've added options, that are disabled by default.
> 
> If I am not missing something - at least on NetBSD - before Thomas'
> commit, both `bzip2' and `zlib' were found and enabled (according
> config.h and a quick `ldd' against gpg2).  So not sure if intended
> or not but a PKGREVISION bump was needed in that case. :)
> 
> (No idea regarding enabling zip and bzip2 unconditionally because
> I am not familiar how gnupg2 can use them but given the other
> dependencies they are probably pretty "tiny" ones :))

Because it's my first commit I'm happy to receive your (everybody on
the list is welcome) advice. I would recommend (as I wrote in my other
email) add it to PKG_SUGGESTED_OPTIONS so the user has still the
flexibility to disable it.

Best regards,
Thomas