Re: CVS commit: pkgsrc/lang/rust

[PHO <pho%cielonegro.org@localhost>]

Oh thanks. I'll update it.

On 4/27/21 6:16 PM, Jonathan Perkin wrote:
> * On 2021-04-27 at 10:10 BST, Masatake Daimon wrote:
> 
>> +.if !empty(MACHINE_PLATFORM:MDarwin-*-*)
>> +# MacOS X 10.7 is the oldest supported version. See
>> +# ${WRKSRC}/src/bootstrap/lib.rs
>> +MAKE_ENV+=    MACOSX_DEPLOYMENT_TARGET="10.7"
>> +.endif
> 
> If anyone is looking to improve constructs like this, first of all using
> .if ${OPSYS} == "Darwin" would be simpler and easier to read, but
> secondly note that MAKE_ENV is in the default list of OPSYSVARS, so this
> entire section can be simplified further to just the single-line:
> 
>  MAKE_ENV.Darwin+=    MACOSX_DEPLOYMENT_TARGET="10.7"
> 
> Using OPSYSVARS has the added benefit of deferred evaluation, so there's
> no need to ensure it is placed after bsd.prefs.mk is included.
> 
> Cheers,
>