Re: CVS commit: pkgsrc/x11/fltk13

[Michael Bäuerle <micha%NetBSD.org@localhost>]

Dr. Thomas Orgis wrote:
> Am Wed, 26 May 2021 16:38:50 +0200 schrieb Michael Bäuerle <micha%NetBSD.org@localhost>: 
> > 
> > I tend to not remove this check (and add the tool dependency), because
> > nobody has complained in the past.  
> 
> So that would be
> 
> USE_TOOLS+= xprop:build
> 
> ?

According to the documentation the ":build" is the default and can be
omitted:
<https://www.netbsd.org/docs/pkgsrc/tools.html#package-tools>

> And I see that pkg-config is missing. Shouldn't that be in USE_TOOLS,
> too? Some packages have it ? way more are using it, I suppose.

Looks like the configure script has fallbacks implemented (can
work without pkg-config too), but if it can use pkg-config and we
can provide it, this would be the cleaner solution.

> > Maybe someone else with deeper X11 knowledge can give a better advice.  
> 
> [...]
> 
> Current patch attached. Fine to commit?

No objection from my side.

-- 
Regards,
Michael