Re: CVS commit: pkgsrc/www/firefox

[Ryo ONODERA <ryo%tetera.org@localhost>]

Hi,

"Nia Alarie" <nia%netbsd.org@localhost> writes:

> Module Name:  pkgsrc
> Committed By: nia
> Date:         Fri Jun 18 18:08:05 UTC 2021
>
> Modified Files:
>       pkgsrc/www/firefox: Makefile
>
> Log Message:
> firefox: Explicitly use autoconf-2.13
>
> Candidate fix for PR pkg/56261

Please stop to commit this incorrect change and same changes for
Mozilla packages.

https://mail-index.netbsd.org/pkgsrc-changes/2021/06/13/msg236827.html
is real cause of the problem.
This commit places autoconf 2.71 as ${WRKDIR}.buildlink/bin/autoconf
and these packages pick up this autoconf 2.71 instead of
${WRKSRC}/.tools/bin/autoconf 2.13.
The commit for lang/llvm breaks pkgsrc's autoconf selection mechanism
and should be reverted.

Thank you.

>
> To generate a diff of this commit:
> cvs rdiff -u -r1.481 -r1.482 pkgsrc/www/firefox/Makefile
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>
> Modified files:
>
> Index: pkgsrc/www/firefox/Makefile
> diff -u pkgsrc/www/firefox/Makefile:1.481 pkgsrc/www/firefox/Makefile:1.482
> --- pkgsrc/www/firefox/Makefile:1.481 Tue Jun 15 13:54:20 2021
> +++ pkgsrc/www/firefox/Makefile       Fri Jun 18 18:08:05 2021
> @@ -1,4 +1,4 @@
> -# $NetBSD: Makefile,v 1.481 2021/06/15 13:54:20 bsiegert Exp $
> +# $NetBSD: Makefile,v 1.482 2021/06/18 18:08:05 nia Exp $
>  
>  FIREFOX_VER=         ${MOZ_BRANCH}${MOZ_BRANCH_MINOR}
>  MOZ_BRANCH=          88.0
> @@ -129,8 +129,8 @@ MOZILLA_NAME=     Browser
>  #.endfor
>  
>  pre-configure:
> -     cd ${WRKSRC} && autoconf
> -     cd ${WRKSRC}/js/src && autoconf
> +     cd ${WRKSRC} && autoconf-2.13
> +     cd ${WRKSRC}/js/src && autoconf-2.13
>       cd ${WRKSRC} && mkdir ${OBJDIR}
>       cd ${WRKSRC}/${OBJDIR} && touch old-configure.vars
>       # Do not fetch Rust Cargo file via network during build
>

-- 
Ryo ONODERA // ryo%tetera.org@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3