CVS commit: pkgsrc/lang/go-bin

["Jonathan Perkin" <jperkin%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   jperkin
Date:           Wed Jul 14 18:38:58 UTC 2021

Modified Files:
        pkgsrc/lang/go-bin: Makefile

Log Message:
go-bin: Hide the signing removal behind DARWIN_CHROOTED.

Unfortunately stripping the signatures breaks running the binaries outside a
chroot according to schmonz, so we're left with no choice but to make this
user-configurable.  It took a lot of effort for me not to name this variable
something far ruder.

This will still mean the go-bin package is ultimately useless when shipped as
part of a package set, but really we only need it for bootstrapping a real
version which should work fine.


To generate a diff of this commit:
cvs rdiff -u -r1.7 -r1.8 pkgsrc/lang/go-bin/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/lang/go-bin/Makefile
diff -u pkgsrc/lang/go-bin/Makefile:1.7 pkgsrc/lang/go-bin/Makefile:1.8
--- pkgsrc/lang/go-bin/Makefile:1.7     Wed Jul 14 14:31:21 2021
+++ pkgsrc/lang/go-bin/Makefile Wed Jul 14 18:38:58 2021
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.7 2021/07/14 14:31:21 jperkin Exp $
+# $NetBSD: Makefile,v 1.8 2021/07/14 18:38:58 jperkin Exp $
 
 PKGNAME=       go-bin-1.14.2
 PKGREVISION=   4
@@ -85,7 +85,12 @@ INSTALLATION_DIRS+=  go-bin
 
 do-install:
        cd ${WRKSRC} && ${PAX} -rw . ${DESTDIR}${PREFIX}/go-bin
-.if !empty(MACHINE_PLATFORM:MDarwin-*-aarch64)
+#
+# Removing the signatures is required to operate inside a chroot, but breaks
+# running them outside.  We're left with no choice but to make it configurable
+# by the user.
+#
+.if !empty(MACHINE_PLATFORM:MDarwin-*-aarch64) && defined(DARWIN_CHROOTED)
        for f in ${DESTDIR}${PREFIX}/go-bin/bin/* \
                 ${DESTDIR}${PREFIX}/go-bin/pkg/tool/darwin_arm64/*; do \
                /usr/bin/codesign --remove-signature $$f; \