Re: CVS commit: pkgsrc/devel/nss/patches

[Tobias Nygren <tnn%NetBSD.org@localhost>]

On Fri, 27 Aug 2021 21:33:18 +0000
matthew green <mrg%netbsd.org@localhost> wrote:

> Module Name:  pkgsrc
> Committed By: mrg
> Date:         Fri Aug 27 21:33:18 UTC 2021
> 
> Added Files:
>       pkgsrc/devel/nss/patches: patch-nss_lib_freebl_sha256-armv8.c
> 
> Log Message:
> fix build on arm64eb: sha512.c and sha256-armv8.c both provided the
> same symbols.  (sha256-x86.c has the same problem, but that file
> already requires little endian so is not a big deal.)

Hello!

Either this patch or the 3.69.1 update earlier today broke the
regular little-endian aarch64 build.
IS_LITTLE_ENDIAN is not defined when the code is built.
I cannot find where/how the constant is defined.
Should it use pkgsrc/mk/endian.mk and set on command line?
If so I wonder how much else of nss silently impacted ... :(

-Tobias