Re: CVS commit: pkgsrc/games

[Patrick Welche <prlw1%cam.ac.uk@localhost>]

On Thu, Nov 18, 2021 at 05:10:47PM +0000, nia wrote:
> On Thu, Nov 18, 2021 at 04:36:05PM +0000, Patrick Welche wrote:
> > On Thu, Nov 18, 2021 at 04:28:17PM +0000, nia wrote:
> > > On Thu, Nov 18, 2021 at 05:17:02PM +0100, Joerg Sonnenberger wrote:
> > > > On Thu, Nov 18, 2021 at 02:45:37PM +0000, Nia Alarie wrote:
> > > > > Module Name:  pkgsrc
> > > > > Committed By: nia
> > > > > Date:         Thu Nov 18 14:45:37 UTC 2021
> > > > > 
> > > > > Modified Files:
> > > > >       pkgsrc/games/assaultcube: Makefile
> > > > >       pkgsrc/games/redeclipse: Makefile
> > > > >       pkgsrc/games/sauerbraten: Makefile
> > > > > 
> > > > > Log Message:
> > > > > games: Mark the Cube 2 engine games as unsupported by RELRO
> > > > > 
> > > > > Unfortunately they use precompiled headers with GCC in a way that
> > > > > would be very difficult to disable.
> > > > 
> > > > This commit doesn't make sense. How is PCH related to RELRO?!
> > > > 
> > > > Joerg
> > > 
> > > GCC's stupid way of dealing with PCH causes compilation failures if
> > > any extra linker flags are forced through. Obviously I would like
> > > to restrict this flag to GCC but unfortunately there's a circular
> > > dependency on disabling RELRO and including bsd.prefs.mk.
> > 
> > How about the PRE vs AP - PENDING question?
> > 
> > 
> > P
> 
> I missed the question, but I think it doesn't make a difference?

I mixed it up with MKPIE (as you changed that default too I made
the association). You checked it makes no difference in the relro
case - OK.

In the mkpie case, xentools415 now has MKPIE_SUPPORTED=no, yet see
Joerg's observation here:

  https://mail-index.netbsd.org/pkgsrc-users/2021/10/15/msg034591.html

and prepending _MKPIE_*FLAGS.gcc (as that's the compiler I'm using)
did advance the xentools415 build with MKPIE_SUPPORTED=yes for me.
(Then broke elsewhere.)


Cheers,

Patrick