CVS commit: pkgsrc/emulators/hercules4sdl

["Olaf Seibert" <rhialto%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   rhialto
Date:           Sun Dec 19 21:26:27 UTC 2021

Modified Files:
        pkgsrc/emulators/hercules4sdl: DESCR Makefile

Log Message:
emulators/hercules4sdl: limit access to suid program hercifc.

It's installed accessible to the new group "hercules":
-r-s--x---  1 root  hercules  9512 Dec 19 21:25 /usr/pkg/bin/hercifc


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 pkgsrc/emulators/hercules4sdl/DESCR
cvs rdiff -u -r1.5 -r1.6 pkgsrc/emulators/hercules4sdl/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/emulators/hercules4sdl/DESCR
diff -u pkgsrc/emulators/hercules4sdl/DESCR:1.1 pkgsrc/emulators/hercules4sdl/DESCR:1.2
--- pkgsrc/emulators/hercules4sdl/DESCR:1.1     Sat Nov  6 16:43:23 2021
+++ pkgsrc/emulators/hercules4sdl/DESCR Sun Dec 19 21:26:27 2021
@@ -13,3 +13,6 @@ Relevant mailing lists include https://g
 https://hercules-390.groups.io/g/group.
 
 This version is developed by SoftDevLabs.
+
+The hercifc program, which is only used when configuring network devices,
+is installed suid root, only accessible by group "hercules".

Index: pkgsrc/emulators/hercules4sdl/Makefile
diff -u pkgsrc/emulators/hercules4sdl/Makefile:1.5 pkgsrc/emulators/hercules4sdl/Makefile:1.6
--- pkgsrc/emulators/hercules4sdl/Makefile:1.5  Sun Dec 19 19:08:19 2021
+++ pkgsrc/emulators/hercules4sdl/Makefile      Sun Dec 19 21:26:27 2021
@@ -1,6 +1,7 @@
-# $NetBSD: Makefile,v 1.5 2021/12/19 19:08:19 rhialto Exp $
+# $NetBSD: Makefile,v 1.6 2021/12/19 21:26:27 rhialto Exp $
 
 PKGNAME=       hercules4sdl-4.4
+PKGREVISION=   1
 DISTNAME=      hyperion-Release_${PKGVERSION_NOREV}
 CATEGORIES=    emulators
 MASTER_SITES=  ${MASTER_SITE_GITHUB:=SDL-Hercules-390/}
@@ -33,8 +34,10 @@ SUBST_SED.prefix=    -e 's,/usr/local,${PRE
 
 CONFIGURE_ARGS+=       --enable-extpkgs=${PREFIX}/lib/hercules4sdl
 
+GROUP=                 hercules
+PKG_GROUPS+=           ${GROUP}
+SPECIAL_PERMS+=                ${PREFIX}/bin/hercifc ${REAL_ROOT_USER} ${GROUP} 4510
 INSTALLATION_DIRS+=    share/examples/hercules
-SPECIAL_PERMS+=                ${PREFIX}/bin/hercifc ${SETUID_ROOT_PERMS}
 
 pre-configure:
        cd ${WRKSRC} && ./autogen.sh