CVS commit: pkgsrc/pkgtools/lintpkgsrc

["Roland Illig" <rillig%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   rillig
Date:           Wed Apr 27 22:25:22 UTC 2022

Modified Files:
        pkgsrc/pkgtools/lintpkgsrc: Makefile

Log Message:
lintpkgsrc: fix Perl warning when parsing variable expressions

When parse-guessing a package Makefile, lintpkgsrc tries to evaluate
variable expressions such as ${VAR:S,from,to,} by passing them through
Perl's eval function.

In a variable expression of the form ${VAR:S,@exec@,${exec},}, this
produced Perl warnings due to the unescaped '@':

        Possible unintended interpolation of @exec in string at
        (eval 63841) line 1.

As a quick fix, skip ':S' modifiers that contain the character '@' for
now.  A proper fix will follow.


To generate a diff of this commit:
cvs rdiff -u -r1.37 -r1.38 pkgsrc/pkgtools/lintpkgsrc/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/pkgtools/lintpkgsrc/Makefile
diff -u pkgsrc/pkgtools/lintpkgsrc/Makefile:1.37 pkgsrc/pkgtools/lintpkgsrc/Makefile:1.38
--- pkgsrc/pkgtools/lintpkgsrc/Makefile:1.37    Sat Jan  1 13:27:37 2022
+++ pkgsrc/pkgtools/lintpkgsrc/Makefile Wed Apr 27 22:25:22 2022
@@ -1,6 +1,6 @@
-# $NetBSD: Makefile,v 1.37 2022/01/01 13:27:37 rillig Exp $
+# $NetBSD: Makefile,v 1.38 2022/04/27 22:25:22 rillig Exp $
 
-PKGNAME=       lintpkgsrc-4.97
+PKGNAME=       lintpkgsrc-4.98
 CATEGORIES=    pkgtools
 
 MAINTAINER=    pkgsrc-users%NetBSD.org@localhost