Re: CVS commit: pkgsrc/math/py-numpy

[David Holland <dholland-pkgchanges%netbsd.org@localhost>]

On Tue, Jun 07, 2022 at 11:23:03AM +0000, Jonathan Perkin wrote:
 > py-numpy: Remove invalid __STDC_VERSION__ on SunOS.
 >    :
 > +# Remove invalid __STDC_VERSION__ setting
 > +BUILDLINK_TRANSFORM.SunOS+= rm:-D__STDC_VERSION__=0
 > +

That's... creative of it. Does it do that on all platforms and it only
fails on Solaris, or is it some kind of fallout from some config issue
not worth debugging?

gcc10 seems to allow it, but it is incorrect to do so (granted, the
standard doesn't say anything about -D, but it's reasonable to expect
it to be equivalent to inserting a #define at the beginning of the
input and then it violates a constraint)

... which is to say, if it's doing that on all platforms, it should
probably be buildlink-removed on all platforms too.

-- 
David A. Holland
dholland%netbsd.org@localhost